Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

regression: PR #143 #154

Closed
pushkarnk opened this issue Jan 19, 2019 · 3 comments
Closed

regression: PR #143 #154

pushkarnk opened this issue Jan 19, 2019 · 3 comments
Assignees
@nethraravindran
Milestone
2019.02

Comments

@pushkarnk
Copy link
Contributor

pushkarnk commented Jan 19, 2019 •
edited
Loading

Kitura tests fail with the changes related to #143

We need to do the following:

  1. Debug all Kitura failures and fix them
  2. Subsequently measure performance and decide if the new changes could be acceptable

I've reverted #143 using #153
@nethraravindran nethraravindran added this to the 2019.02 milestone Jan 20, 2019
@nethraravindran
Copy link
Contributor

#143 caused failures in Kitura due to invalid url formed using incorrect components _urlComponents?.path = _urlString
In this _urlString is the uri string from requestHead containing both path and percent encoded query. Hence it has to be split and assigned to path and percentEncodedQuery of the URLComponents respectively.

@nethraravindran nethraravindran mentioned this issue Jan 21, 2019
Merged
@nethraravindran
Copy link
Contributor

nethraravindran commented Jan 21, 2019 •
edited
Loading

Fixed in #156

@pushkarnk
Copy link
Contributor Author

Merged #156. Thanks @nethraravindran

@pushkarnk pushkarnk mentioned this issue Feb 6, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nethraravindran nethraravindran

Labels
None yet
Projects
None yet
Milestone
2019.02
Development

No branches or pull requests
2 participants
@pushkarnk @nethraravindran