Revert " Build urlURL
using URLComponents"
#153
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 46fbee0.
These commit has caused many regressions in Kitura tests. Most of the 124 failures are around percent encoding and queries. I was able to debug one of the issues:
_urlComponents?.path = _urlString
isn't enough. We'd need the split the_urlString
intopath
andquery
and take care of percent encoding.This brings down the number of failures to 30. But it also cancels out any of the performance gains we saw with this change.
Because this commit has been tagged, I am reverting it and opening an issue to investigate further.