Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: SwiftLint errors and warnings #122

Merged
merged 1 commit into from
Dec 22, 2018

Conversation

nethraravindran
Copy link
Contributor

@nethraravindran nethraravindran commented Dec 21, 2018

This PR enforces Swift style and conventions based on https://github.com/realm/SwiftLint and violations for following rules has been fixed.

  • Closing Brace Spacing
  • Closure Spacing
  • Colon
  • Control Statement
  • Empty Enum Arguments
  • Empty Parameters
  • Empty Parentheses with Trailing Closure
  • Identifier Name
  • Implicit Getter
  • Implicitly Unwrapped Optional
  • Mark
  • Multiple Closures with Trailing Closure
  • Redundant Nil Coalescing
  • Redundant Void Return
  • Switch and Case Statement Alignment
  • Trailing Closure
  • Trailing Comma
  • Trailing Semicolon
  • Trailing Whitespace
  • Vertical Whitespace
  • Vertical Whitespace Between Cases
  • Vertical Whitespace before Closing Braces
  • Vertical Whitespace after Opening Braces
  • Void Return

Rules Ref: https://github.com/realm/SwiftLint/blob/master/Rules.md

@nethraravindran nethraravindran added this to the 2018.26 milestone Dec 21, 2018
@nethraravindran nethraravindran self-assigned this Dec 21, 2018
@@ -37,19 +37,19 @@ public class ClientResponse {
/// Minor version of HTTP of the response
public var httpVersionMinor: UInt16?

internal var _headers: HTTPHeaders?
internal var httpHeaders: HTTPHeaders?
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you mean to rename this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ianpartridge Yes, by rules it can contain only alphanumeric characters.

@pushkarnk pushkarnk merged commit 34493de into Kitura:master Dec 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants