Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v0.96.8 bugfix infantry battlegroups #846

Closed
wants to merge 2 commits into from

Conversation

nicoman35
Copy link

Fix. Only one of the created infantry battlegroups moved towards designated target.

Q A
Bug fix? yes
New feature? no
Needs wipe? no

Description:

When infantry only counter attack battlegroups are spawned, only one of the created battlegroups are charging towards their designated target. This patch should change this and let all spawned battlegroups move towards target.

Content:

  • Content part

Successfully tested on:

  • Local MP
  • Dedicated MP

Fix. Only one of the created infantry battlegroups moved towards designated target.
@nicoman35 nicoman35 changed the title - bugfix inf battlegroups v0.96.8 bugfix infantry battlegroups Nov 14, 2020
Copy link

@mwpowellhtx mwpowellhtx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Genuinely curious about this change... So new AI is being spawned every time a new _grp is pushed onto the _bg_groups array? How is that any different than simply spawning the AI when we see the _grp? Besides introducing potential to miss the correct AI execution? i.e. assuming the scheduler sees spawn in the correct order, which I do not think is guaranteed, IIRC.

@mwpowellhtx
Copy link

I see what is going on with the inner group and trailing group being created. Assuming the count is the desired count, why not just create the group and be done with it? Then there is also a potential for every 8th group to be created only?

@nicoman35
Copy link
Author

The orignial version had the bug. I fixed it, and I could play with working infantry assaults. Given the fact, that I am an amateur coder, there is a better solution for sure. So go ahead and pull request your version.

@Beeperz
Copy link

Beeperz commented Aug 3, 2022

Have tested this edit on my server with 0.96.7, looks like work good.

peckcat added a commit to peckcat/PCAT-Liberation that referenced this pull request Feb 1, 2023
# Fix filename error.
 - "custom east.sqf" -> "custom_east.sqf"

# Remove build preset workshopid tag.

# Modify .gitignore

# Update stringtable.xml
 - Including this translation.
 - New Secondary Objective 'Humanitarian Aid'
 - KillahPotatoes#894

# bugfix infantry battlegroups
 - KillahPotatoes#846
Apricot-ale added a commit to Apricot-ale/KP-Liberation-APR that referenced this pull request Feb 28, 2023
Apricot-ale added a commit to Apricot-ale/KP-Liberation-APR that referenced this pull request Mar 2, 2023
@some-evil-kitty
Copy link
Collaborator

I think this one is redundant now.

@veteran29
Copy link
Member

Superseded by #942

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants