-
-
Notifications
You must be signed in to change notification settings - Fork 307
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Battle Group Spawning + AI #942
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed infantry battlegroups to not "lose" members, enable lambs reinforcements on them, change "reset" listener to server event
spawn returns a script handle, not a vehicle, meaning vehicle battlegroups lose track of their spawned vehicles
carlmylo
added a commit
to moistbois/Moist-Liberation-APR
that referenced
this pull request
Nov 15, 2023
Originally from: KillahPotatoes#942 Co-Authored-By: some-evil-kitty <[email protected]>
ralreegorganon
pushed a commit
to ralreegorganon/KP-Liberation
that referenced
this pull request
Dec 2, 2023
Originally from: KillahPotatoes#942 Co-Authored-By: some-evil-kitty <[email protected]>
Crowdedlight
added a commit
to Crowdedlight/KP-Liberation-war-room
that referenced
this pull request
Mar 4, 2024
3 tasks
veteran29
requested changes
Mar 14, 2024
Missionframework/scripts/server/battlegroup/spawn_battlegroup.sqf
Outdated
Show resolved
Hide resolved
Missionframework/scripts/server/battlegroup/spawn_battlegroup.sqf
Outdated
Show resolved
Hide resolved
Missionframework/scripts/server/battlegroup/spawn_battlegroup.sqf
Outdated
Show resolved
Hide resolved
veteran29
reviewed
Mar 14, 2024
Missionframework/scripts/server/battlegroup/spawn_battlegroup.sqf
Outdated
Show resolved
Hide resolved
veteran29
reviewed
Mar 14, 2024
Missionframework/scripts/server/battlegroup/spawn_battlegroup.sqf
Outdated
Show resolved
Hide resolved
veteran29
requested changes
Mar 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One behaviour question.
Please try to keep indentation consistent in the codebase as it makes it easier to do code reviews.
Co-authored-by: Filip Maciejewski <[email protected]>
veteran29
reviewed
Mar 14, 2024
Missionframework/scripts/server/battlegroup/spawn_battlegroup.sqf
Outdated
Show resolved
Hide resolved
My bad
veteran29
approved these changes
Mar 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Content:
Successfully tested on: