Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CBA based features implemention / Refactoring / Code cleanup #490

Merged
merged 17 commits into from
Sep 8, 2018
Merged

CBA based features implemention / Refactoring / Code cleanup #490

merged 17 commits into from
Sep 8, 2018

Conversation

veteran29
Copy link
Member

@veteran29 veteran29 commented Sep 8, 2018 •
edited
Loading

Q A
Bug fix? no
New feature? no
Needs wipe? no
Fixed issues Closes #467

Description:

Refactoring of existing mission functionalities with usage of CBA for streamlined further development and better scripts reliability.

Content:

  • Replaced redundant functions with CBA variants
  • Moved sector loop to unscheduled
  • Moved player in fob check to unscheduled
  • Moved sector handler to unscheduled
  • Cargo removal param
  • Moved save timer to unscheduled
  • Made common_spawnVehicle unscheduled
  • Added common_clearVehicleCargo function
  • Moved respawnable vehicles wreck deletion handling to unscheduled
  • Optimized performance of core_areUnitsNear

Tested on:

  • Local MP Vanilla
  • Local MP ACE
  • Dedicated MP Vanilla
  • Dedicated MP ACE

@veteran29
Use CBA_fnc_players instead of own implementation
6afa065
@veteran29
Move FOB event loop to CBA PFH Object
f286100
@veteran29
Make common_spawnVehicle not suspendable
99f447a
@veteran29
Update common_spawnVehicle edit date
f72b28f
@veteran29
Fix config guard
c485ce2 
I think this change got lost in some rebase :|
@veteran29
Add common_clearVehicleCargo
6c76afa
@veteran29
Add ClearVehicleCargo param, move cargo clear to event handler
53a36e3
@veteran29
Move eventLoop init function to top of file
97f80a7 
Makes the code more readable and also stops linter from notifying about possible undefined vars.
@veteran29
Move respawnable vehicles wreck handling to unscheduled
7040010
@veteran29
Optimize core_areUnitsNear
61a0168
@veteran29
Move sector activation checks to unscheduled
71727a6
@veteran29
Replace common_createNamespace with CBA implementation
8baca03
@veteran29
Sector monitor, allow to go over sector cap in single loop, remove debug
f8926d9
@veteran29
Move sector handling to unscheduled
66b0266
@veteran29
Move save timer to unscheduled
a5c6d5d
@veteran29
Remove unnecessary line in eventLoop
921c979
@veteran29 veteran29 added this to the Sprint 5 milestone Sep 8, 2018
@veteran29 veteran29 requested a review from Wyqer September 8, 2018 15:58
@veteran29 veteran29 merged commit 61bacde into v0.97S5 Sep 8, 2018
@Wyqer Wyqer added done and removed review/QA labels Sep 9, 2018
@veteran29 veteran29 deleted the 0.97S5-467 branch September 10, 2018 07:45
@Wyqer Wyqer mentioned this pull request Sep 10, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Wyqer Wyqer Wyqer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Sprint 5
Development

Successfully merging this pull request may close these issues.
2 participants
@veteran29 @Wyqer