Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mission initialization overhaul #483

Merged
merged 11 commits into from
Aug 31, 2018
Merged

Mission initialization overhaul #483

merged 11 commits into from
Aug 31, 2018

Conversation

Wyqer
Copy link
Member

@Wyqer Wyqer commented Aug 31, 2018

Q A
Bug fix? no
New feature? no
Needs wipe? no
Fixed issues #479

Description:

As stated in the dev task, the calls for the module initialization files are now gone. It's moved to a initModule function which is flagged for postInit execution in the CfgFunctions. One preInit function for the initialization is created to handle the parameters etc. before everything else is loaded.
In the next step the content from the vanilla init files are sensible moved to the module initializations. Only the onPlayerRespawn is left as vanilla event handling file. I've also thought about just creating a function for it and register a onPlayerRespawn event handler, but I decided to not do that and keep the vanilla file.
This changes results in the state, that modules just need to be "registered" via the functions and ui fetch file, not in one of the init files anymore, which was the general goal for the task.

Content:

  • Removed initModule.sqf files.
  • Created pre-/postInit functions for module initialization.
  • Moved all content from the initServer, initPlayerLocal and init file to the initialization functions.
  • Created some log output for mission initialization.
  • Moved the "missionstart" log output to the Config Guard function.
  • Renamed folders of the player and admin menu to be equal to the function abbreviation.
  • Fixed some missing semicolons in the ui files. Nothing critical, just created a log output.

Tested on:

  • Local MP Vanilla
  • Local MP ACE
  • Dedicated MP Vanilla
  • Dedicated MP ACE

@Wyqer Wyqer requested a review from veteran29 August 31, 2018 13:56
@Wyqer Wyqer changed the title V0.97 s5 479 Mission initialization overhaul Aug 31, 2018
@Wyqer Wyqer merged commit cfcf945 into v0.97S5 Aug 31, 2018
@Wyqer Wyqer added done and removed review/QA labels Aug 31, 2018
@Wyqer Wyqer added this to the Sprint 5 milestone Aug 31, 2018
@Wyqer Wyqer deleted the v0.97S5-479 branch August 31, 2018 21:09
@Wyqer Wyqer mentioned this pull request Sep 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants