-
-
Notifications
You must be signed in to change notification settings - Fork 312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mission initialization overhaul #483
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
veteran29
reviewed
Aug 31, 2018
Missionframework/modules/00_init/fnc/fn_init_postInitModule.sqf
Outdated
Show resolved
Hide resolved
veteran29
reviewed
Aug 31, 2018
veteran29
approved these changes
Aug 31, 2018
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
As stated in the dev task, the calls for the module initialization files are now gone. It's moved to a initModule function which is flagged for postInit execution in the CfgFunctions. One preInit function for the initialization is created to handle the parameters etc. before everything else is loaded.
In the next step the content from the vanilla init files are sensible moved to the module initializations. Only the onPlayerRespawn is left as vanilla event handling file. I've also thought about just creating a function for it and register a onPlayerRespawn event handler, but I decided to not do that and keep the vanilla file.
This changes results in the state, that modules just need to be "registered" via the functions and ui fetch file, not in one of the init files anymore, which was the general goal for the task.
Content:
Tested on:
Local MP ACEDedicated MP ACE