Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Floating build camera at FOB #441

Merged
merged 4 commits into from
Jul 1, 2018
Merged

Floating build camera at FOB #441

merged 4 commits into from
Jul 1, 2018

Conversation

veteran29
Copy link
Member

@veteran29 veteran29 commented Jul 1, 2018

Q A
Bug fix? no
New feature? yes
Needs wipe? no
Fixed issues #415

Description:

Initial implementation of build camera. For now it is really simple, it has no resource system integration as it is not ready yet.

Content:

  • Floating camera available at FOB
  • Dialog that allows to select what has to be built
  • Build selected object at position

Flaws that need to be fixed in further development:

  • Scrolling the item list zooms camera
  • Missing item collision detection
  • Camera is not limited to FOB area
  • When tab is switched tab buttons "vibrate" a little bit, Might be not possible to fix this, also happens in vanilla zeus. (optionaly scale animation can be removed)
  • Camera should be closed when player is killed
  • Main display handling script is too fat, some logic needs to be moved to outside functions

Tested on:

  • Local MP Vanilla
  • Local MP ACE
  • Dedicated MP Vanilla
  • Dedicated MP ACE

@veteran29 veteran29 requested a review from Wyqer July 1, 2018 17:25
@Wyqer Wyqer added the Review/QA label Jul 1, 2018
Copy link
Member

@Wyqer Wyqer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As a general point to start from it's fine. But as you already said, it'll need some more tweaks and the current state is WIP and not considered as finished. But it's at least the camera view for building, of course.

@veteran29 veteran29 merged commit 7e6a70b into v0.97S3 Jul 1, 2018
@veteran29 veteran29 deleted the v0.97S3-415 branch July 1, 2018 18:33
@veteran29 veteran29 added Done and removed Review/QA labels Jul 1, 2018
@veteran29 veteran29 mentioned this pull request Jul 1, 2018
@Wyqer Wyqer added this to the Sprint 3 milestone Jul 2, 2018
@Wyqer Wyqer mentioned this pull request Jul 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants