2.0.0-dev.1.4 #50
2.0.0-dev.1.4 #50
Conversation
lexaknyazev
changed the title
|
|
@donmccurdy This PR should fix #49. |
|
Sorry for the delay @lexaknyazev... Short week this week, a little swamped here. Will get to this soon as I can. |
|
Alpha cutoff and Firefox/Edge fixes look good to me thanks! |
ISSUES.md
Outdated
| |28|UNUSED_EXTENSION_REQUIRED|Unused extension '`%1`' cannot be required.|Error| | ||
| |29|UNRESERVED_EXTENSION_PREFIX|Extension uses unreserved extension prefix '`%1`'.|Warning| | ||
| |30|NODE_EMPTY|Empty node encountered.|Information| | ||
| |31|NON_RELATIVE_URI|Non-relative URI found: `%1`.|Warning| |
There was a problem hiding this comment.
Do these error numbers do any good for users, given they can change between versions? For example NON_RELATIVE_URI changed from 29 to 31 here. If these aren't stable, any reason not to get rid of them?
There was a problem hiding this comment.
I've used them back in a day to keep track on the total amount of recognized issues. They serve no purpose now, so let's remove them.
There was a problem hiding this comment.
Also, should we sort messages by code? Current order is semi-random.
|
|
||
| // https://github.com/KhronosGroup/glTF/blob/master/extensions/Prefixes.md | ||
| const List<String> kReservedPrefixes = const <String>[ | ||
| 'KHR_', |
There was a problem hiding this comment.
I wonder if we'll need a reminder to update this list from time to time.
There was a problem hiding this comment.
What would you suggest? Adding a comment here or adding a note to Prefixes.md, or both?
There was a problem hiding this comment.
We've already got the link here in a comment. I think Prefixes.md should get a note (after this is merged) that any changes there should be copied here (or bump the glTF-Validator maintainers to do it).
| <div id="outputZone"> | ||
| <p><em>Validation is performed locally in your browser. Submitted assets are not uploaded.</em></p> |
|
Published |
|
https://gltf-viewer.donmccurdy.com/ validation working in Firefox now, thanks! |
DUPLICATE_ELEMENTS,UNSUPPORTED_EXTENSION, andUNUSED_EXTENSION_REQUIRED.UNRESERVED_EXTENSION_PREFIX.