-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reason to ignore alphaCutoff in BLEND mode? #1158
Comments
@donmccurdy I think the spec has been misread, it makes no sense so it's an issue and I'll take a look at it. The other point is that the model is actually using dithering transparency, and we currently fallback on alpha blending during export, which is probably wrong (alpha masking is more appropriate for this part). If there is an update or an extension that I missed to handle this, it could be updated, but if not I'm not sure yet how to handle this correctly. |
Upcoming |
Much of the original discussion of this happened in #822. |
@AurL yes, in this case mask gives a more reasonable result (below). Not sure whether it would be possible to detect which is appropriate in cases like this. @emackey Thanks, that's helpful. What I don't see in that discussion is a reply to @erich666's suggestion of an Is that something we should consider patching in the future, with a 2.X release, by adding a /cc @bghgary |
I am not an expert in this area, so I won't dive into details, but this is complicated. There are multiple ways to combine the two modes together and they are not consistent across implementations. It also depends on usage/performance. The implementation note hits on this a bit:
But you are right that there is no way to specify this explicitly in the spec right now.
I would prefer this. Using the current spec for optical transparency is not ideal. |
Hi all. |
Closing to merge discussion into #1302. |
From the spec:
I came across this Sketchfab model (mildly NSFW) in a three.js issue recently, which provides
alphaCutoff: 0.5
andalphaMode: "BLEND"
:result in three.js:
The spec is clear enough on this, so I'm just wondering:
(1) what is the reasoning for specifying that
alphaCutoff
should be ignored?(2) should we check in with the Sketchfab folks about this?
(3) should this be changed in a future version of the spec?
The text was updated successfully, but these errors were encountered: