tests: Disable message limit in tests #9036
Open
+14
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI Vulkan-ValidationLayers build queued with queue ID 325549. |
|
CI Vulkan-ValidationLayers build # 18342 running. |
|
CI Vulkan-ValidationLayers build # 18342 failed. |
ziga-lunarg
force-pushed
the
ziga-tests-disable-message-limit
branch
from
5dec776 to
74a41a3
Compare
|
CI Vulkan-ValidationLayers build queued with queue ID 325577. |
|
CI Vulkan-ValidationLayers build # 18343 running. |
|
CI Vulkan-ValidationLayers build # 18343 passed. |
| @@ -320,6 +320,16 @@ VkSamplerCreateInfo SafeSaneSamplerCreateInfo() { | |||
| } | |||
|
|
|||
| void VkLayerTest::Init(VkPhysicalDeviceFeatures *features, VkPhysicalDeviceFeatures2 *features2, void *instance_pnext) { | |||
| const VkBool32 enable_message_limit = false; | |||
There was a problem hiding this comment.
putting it in here seems like a great way for people to get burned if they go
RETURN_IF_SKIP(InitFramework(something_else));
RETURN_IF_SKIP(InitState());
I also created a static VkLayerSettingsCreateInfoEXT kDisableMessageLimit that can be used here
ziga-lunarg
force-pushed
the
ziga-tests-disable-message-limit
branch
from
74a41a3 to
f9d16dd
Compare
|
CI Vulkan-ValidationLayers build queued with queue ID 325898. |
|
CI Vulkan-ValidationLayers build # 18352 running. |
|
CI Vulkan-ValidationLayers build # 18352 passed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The message limit should be disabled in the tests by default. Some tests are currently failing when reaching this limit.