layers: Warn if VkLayerSettingEXT has wrong type or duplicated #9032
+398
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI Vulkan-ValidationLayers build queued with queue ID 324969. |
|
CI Vulkan-ValidationLayers build # 18337 running. |
|
CI Vulkan-ValidationLayers build # 18337 failed. |
spencer-lunarg
force-pushed
the
spencer-lunarg-setting
branch
from
93b4e31 to
36aa939
Compare
|
CI Vulkan-ValidationLayers build queued with queue ID 324991. |
|
CI Vulkan-ValidationLayers build # 18338 running. |
|
CI Vulkan-ValidationLayers build # 18338 passed. |
filnet
reviewed
Dec 16, 2024
artem-lunarg
approved these changes
Dec 16, 2024
spencer-lunarg
force-pushed
the
spencer-lunarg-setting
branch
from
36aa939 to
d525ae9
Compare
|
CI Vulkan-ValidationLayers build queued with queue ID 325735. |
|
CI Vulkan-ValidationLayers build # 18347 running. |
|
CI Vulkan-ValidationLayers build # 18347 failed. |
spencer-lunarg
force-pushed
the
spencer-lunarg-setting
branch
from
d525ae9 to
3aed97d
Compare
|
CI Vulkan-ValidationLayers build queued with queue ID 325855. |
|
CI Vulkan-ValidationLayers build # 18351 running. |
|
CI Vulkan-ValidationLayers build # 18351 passed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #9028
We ultimately need a more streamline, auto-generated way of doing this type of checks (else adding a setting only gets more complicated again)
For now, at least warn the user if they have the wrong
VkLayerSettingTypeEXTor duplicated a setting