layers: Add Extension Checks for Layer Extensions #8765
Conversation
|
CI Vulkan-ValidationLayers build queued with queue ID 289587. |
|
CI Vulkan-ValidationLayers build # 17847 running. |
|
CI Vulkan-ValidationLayers build # 17847 failed. |
| // good to have for completeness | ||
| if (!local_instance_extensions.vk_ext_layer_settings && | ||
| vku::FindStructInPNextChain<VkLayerSettingsCreateInfoEXT>(pCreateInfo->pNext)) { | ||
| skip |= LogError("UNASSIGNED-VkInstanceCreateInfo-layer-settings", instance, |
There was a problem hiding this comment.
self note these are VUID-VkInstanceCreateInfo-pNext-10242/VUID-VkInstanceCreateInfo-pNext-10243/VUID-VkInstanceCreateInfo-pNext-10244 now
spencer-lunarg
force-pushed
the
spencer-lunarg-layer-ext
branch
from
e0795ba to
544d14a
Compare
|
CI Vulkan-ValidationLayers build queued with queue ID 296446. |
|
CI Vulkan-ValidationLayers build # 17925 running. |
|
CI Vulkan-ValidationLayers build # 17925 failed. |
spencer-lunarg
force-pushed
the
spencer-lunarg-layer-ext
branch
from
544d14a to
e5931c0
Compare
|
CI Vulkan-ValidationLayers build queued with queue ID 296502. |
|
CI Vulkan-ValidationLayers build # 17926 running. |
|
CI Vulkan-ValidationLayers build # 17926 failed. |
|
CI Vulkan-ValidationLayers build queued with queue ID 297014. |
|
CI Vulkan-ValidationLayers build # 17933 running. |
|
CI Vulkan-ValidationLayers build # 17933 failed. |
|
CI Vulkan-ValidationLayers build queued with queue ID 297394. |
|
CI Vulkan-ValidationLayers build # 17938 running. |
|
CI Vulkan-ValidationLayers build # 17938 failed. |
spencer-lunarg
force-pushed
the
spencer-lunarg-layer-ext
branch
from
e5931c0 to
df5c5b5
Compare
|
CI Vulkan-ValidationLayers build queued with queue ID 302021. |
|
CI Vulkan-ValidationLayers build # 17998 running. |
|
CI Vulkan-ValidationLayers build # 17998 failed. |
|
CI Vulkan-ValidationLayers build queued with queue ID 302333. |
|
CI Vulkan-ValidationLayers build # 18003 running. |
|
CI Vulkan-ValidationLayers build queued with queue ID 302449. |
|
CI Vulkan-ValidationLayers build # 18011 running. |
|
CI Vulkan-ValidationLayers build # 18011 failed. |
|
CI Vulkan-ValidationLayers build queued with queue ID 302852. |
|
CI Vulkan-ValidationLayers build # 18027 running. |
|
CI Vulkan-ValidationLayers build # 18027 failed. |
From #8760 (comment) and matches spec change in https://gitlab.khronos.org/vulkan/vulkan/-/merge_requests/6979
This makes sure if you are using an extension like
VK_EXT_layer_settingsyou need theVkInstanceCreateInfo::ppEnabledExtensionNameslike any other extensioncc @charles-lunarg to make sure I am not overlooking anything obvious