Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

syncval: aliasing design update #5801

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

syncval: aliasing design update #5801

wants to merge 1 commit into from

Conversation

jzulauf-lunarg
Copy link
Contributor

Design for changes needed to support accurate hazard detection of consistent and inconsistent memory aliases.

@jzulauf-lunarg jzulauf-lunarg requested a review from a team as a code owner May 4, 2023 21:34
@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build queued with queue ID 10683.

@jzulauf-lunarg jzulauf-lunarg marked this pull request as draft May 4, 2023 21:35
@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build # 11956 running.

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build # 11956 failed.

@jzulauf-lunarg jzulauf-lunarg force-pushed the zulauf-aliasing-doc-changes branch from 8b8c01e to f4e66b5 Compare May 12, 2023 21:40
@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build queued with queue ID 15828.

@jzulauf-lunarg jzulauf-lunarg force-pushed the zulauf-aliasing-doc-changes branch from f4e66b5 to bd17dd8 Compare May 12, 2023 21:45
@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build queued with queue ID 15841.

@jzulauf-lunarg jzulauf-lunarg force-pushed the zulauf-aliasing-doc-changes branch from bd17dd8 to 9f6b094 Compare May 12, 2023 21:54
@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build queued with queue ID 15844.

@jzulauf-lunarg jzulauf-lunarg force-pushed the zulauf-aliasing-doc-changes branch from 9f6b094 to cac63ae Compare May 12, 2023 21:56
@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build queued with queue ID 15847.

@jzulauf-lunarg jzulauf-lunarg force-pushed the zulauf-aliasing-doc-changes branch from cac63ae to 9a12c11 Compare May 12, 2023 22:01
@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build queued with queue ID 15849.

@jzulauf-lunarg jzulauf-lunarg force-pushed the zulauf-aliasing-doc-changes branch from 9a12c11 to bd54a6f Compare May 12, 2023 22:33
@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build queued with queue ID 15879.

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build # 15879 cancelled.

@jzulauf-lunarg jzulauf-lunarg force-pushed the zulauf-aliasing-doc-changes branch from bd54a6f to 4683654 Compare May 26, 2023 14:21
@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build queued with queue ID 7344.

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build # 12195 running.

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build # 12195 failed.

@jzulauf-lunarg jzulauf-lunarg force-pushed the zulauf-aliasing-doc-changes branch from 4683654 to c3633d8 Compare June 15, 2023 22:49
@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build queued with queue ID 17907.

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build # 12390 running.

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build # 12390 passed.

@jzulauf-lunarg jzulauf-lunarg force-pushed the zulauf-aliasing-doc-changes branch from c3633d8 to 267f035 Compare June 16, 2023 17:22
@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build queued with queue ID 18409.

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build # 12399 running.

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build # 12399 passed.

@jzulauf-lunarg jzulauf-lunarg force-pushed the zulauf-aliasing-doc-changes branch from 267f035 to c740736 Compare June 16, 2023 21:18
@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build queued with queue ID 18606.

@jzulauf-lunarg jzulauf-lunarg added the Synchronization Synchronization Validation Object Issue label Jun 16, 2023
@jzulauf-lunarg jzulauf-lunarg marked this pull request as ready for review June 16, 2023 21:20
@jzulauf-lunarg jzulauf-lunarg changed the title syncval: WIP aliasing design update syncval: aliasing design update Jun 16, 2023
@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build # 12403 running.

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build # 12403 passed.

artem-lunarg
artem-lunarg reviewed Jun 20, 2023
View reviewed changes
docs/synchronization.md Outdated
| Buffer (liinear) | ***B*** | [0, 512) | |
| Image (Tiled) | ***I0*** | [128, 256) | |
| Image (Tiled) | ***I1*** | [128, 256) | Consistent with ***I1*** |
| Image (Linear) | ***I2*** | [128, 384) | |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Image (Linear): [192, 384) to match the image?

artem-lunarg
artem-lunarg reviewed Jun 20, 2023
View reviewed changes
docs/synchronization.md Outdated

### AccessContext Updates

There are several `AccessContext::DetectHazard` member that apply to images. Theses differ by hazard detection functors use, and the parameter to the range generators. Eventually all of these call into the generic AccessContext::DetectHazard operating on a single range. In order to avoid duplication of the aliasing logic, each of these need to be modified to supply a range generation object factory callable encapsulating the member specific range generation function arguments and creation, and taking the object base address as an argument.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: typo: member that apply -> members that apply, Theses -> These.

@jzulauf-lunarg
docs: Aliasing design update
1b59e71 
This is a preliminary design for the addition of aliasing support to
syncval.
@jzulauf-lunarg jzulauf-lunarg force-pushed the zulauf-aliasing-doc-changes branch from c740736 to 1b59e71 Compare June 21, 2023 21:24
@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build queued with queue ID 21144.

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build # 12464 running.

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build # 12464 failed.

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build queued with queue ID 21917.

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build # 12492 running.

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build # 12492 passed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@artem-lunarg artem-lunarg artem-lunarg approved these changes

@jeremyg-lunarg jeremyg-lunarg Awaiting requested review from jeremyg-lunarg

Assignees
No one assigned
Labels
Synchronization Synchronization Validation Object Issue
Projects
Synchronization Validation
Status: In progress
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jzulauf-lunarg @ci-tester-lunarg @artem-lunarg