Cleanup VVL build warnings #323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shannon-lunarg
requested review from
chrisforbes,
mark-lunarg,
tobine,
daveh-lunarg and
jzulauf-lunarg
jzulauf-lunarg
approved these changes
Sep 11, 2018
| @@ -92,7 +92,7 @@ static bool IsAcquireOp(const COMMAND_POOL_NODE *pool, const Barrier *barrier) { | |||
| return (assume_transfer || IsTransferOp(barrier)) && (pool->queueFamilyIndex == barrier->dstQueueFamilyIndex); | |||
| } | |||
|
|
|||
| inline const bool IsSpecial(const uint32_t queue_family_index) { | |||
There was a problem hiding this comment.
Not sure what I was thinking when I typed that. This is a correct fix
There was a problem hiding this comment.
Agreed! I just verified the same fix. Also: https://stackoverflow.com/questions/8716330/purpose-of-returning-by-const-value 👍 👍 👍 Please merge soon.
There was a problem hiding this comment.
@jzulauf-lunarg This is mostly my doing. I moved the const around which changed what was being specified as constant--this action is more than likely the result of needing to const functions every which way in my university C++ course.
shannon-lunarg
force-pushed
the
shannon-is-special
branch
from
66f757f to
9ffeb38
Compare
|
Changes are now on master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
IsSpecialfunction was throwing build warnings, informing us that type qualifiers were being ignored.This change removes the offending qualifier.