Prevent null pointer access for GetSwapchainImages out-of-order calls #1975
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
layers/core_validation.cpp
Outdated
| uint32_t acquired_images = 0; | ||
| for (auto item : swapchain_data->images) { | ||
| auto image_state = GetImageState(item.image); | ||
| if ((image_state) && image_state->acquired) { |
There was a problem hiding this comment.
Why not modify the lambda?
There was a problem hiding this comment.
Ignorance! Pushed a redo.
Validation could croak if this two-part query was only called by the application to retreive the count but not the images. Change-Id: Iee9ad53bfbd59c6f34054c8ab48161037b1db5ef
mark-lunarg
force-pushed
the
markl_swapchain_crash
branch
from
74bcf20 to
ed01d8a
Compare
jeremy-lunarg
approved these changes
Jun 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Validation could croak if this two-part query was only called by the application to retrieve the count but not the images.
i.e., though it seems weird, it's legal to do this:
Wrote a positive test for this case, but it dies on Android consistently and so left it out. Highlighted this in BP tracking issue #24 (it was already there) to spit out a warning when this happens.
Fixes #1955.