Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add VkImageResolve VUIDs #1917

Merged

Conversation

sfricke-samsung
Copy link
Contributor

VUID-VkImageResolve-srcImage-00268
VUID-VkImageResolve-srcImage-00271
VUID-VkImageResolve-srcImage-00273
VUID-VkImageResolve-dstImage-00276
VUID-VkImageResolve-dstImage-00278

I wasn't able to find support on my any local GPUs for a 1D multi-sampled image so 00271 doesn't have a test... I doubt that anyone will actually hit 00271 as not sure who supports multi-sampled 1D images to do the resolve command from

@mark-lunarg mark-lunarg self-assigned this Jun 8, 2020
@mark-lunarg
Copy link
Contributor

Running through CI.

layers/buffer_validation.cpp Outdated Show resolved Hide resolved
layers/buffer_validation.cpp Outdated Show resolved Hide resolved
@sfricke-samsung sfricke-samsung force-pushed the sfricke-samsung-v-resolve branch from 4703b5f to 5f86487 Compare June 11, 2020 04:00
@sfricke-samsung sfricke-samsung force-pushed the sfricke-samsung-v-resolve branch from 5f86487 to cd1f340 Compare June 12, 2020 04:35
@mark-lunarg
Copy link
Contributor

Looks good! Running through CI.

@mark-lunarg mark-lunarg merged commit f78d059 into KhronosGroup:master Jun 12, 2020
@sfricke-samsung sfricke-samsung deleted the sfricke-samsung-v-resolve branch July 1, 2020 04:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants