Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move CmdAttachment Perf Warning to BP and Setup BP Tests #1362

Merged
merged 4 commits into from
Nov 14, 2019
Merged

Move CmdAttachment Perf Warning to BP and Setup BP Tests #1362

merged 4 commits into from
Nov 14, 2019

Conversation

camden-lunarg
Copy link
Contributor

Resolves #1307 tracked in #24 which moves a performance warning to BP.

I also needed to set up BP test file for all future BP tests. Migrated one test over to BP which is related to the warning in #1307

mark-lunarg
mark-lunarg requested changes Nov 7, 2019
View reviewed changes
Copy link
Contributor

@mark-lunarg mark-lunarg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's fix the C-F thing and run it through again to get a CI pass. The test class can be added/fixed later. Otherwise LGTM.

layers/best_practices.cpp Outdated Show resolved Hide resolved
tests/vklayertests_best_practices.cpp Show resolved Hide resolved
tests/vklayertests_best_practices.cpp Outdated Show resolved Hide resolved
@camden-lunarg camden-lunarg force-pushed the camden_BP_issue24_1307 branch 2 times, most recently from 55877ba to 237f980 Compare November 8, 2019 21:17
@camden-lunarg
layers: Add DrawCmd perf warning to Best Practices
f4206ce 
Change-Id: I7b4530393df8ff7b93f2ceb484ff49a1fb6e92c8
@camden-lunarg
layers: Remove DrawCmd perf warning from Buf Val
5758258 
resolves #1307 which was tracked in #24

Change-Id: If34c89c4fd40d75803ea2d38539a2050570cf374
@camden-lunarg
CMake: Add vklayertests_best_practices.cpp to CMake
ca8f9cb 
Change-Id: If60d16207680a5e549ed864b15391e6a0f7bbd53
@camden-lunarg camden-lunarg force-pushed the camden_BP_issue24_1307 branch from 237f980 to 29b16be Compare November 8, 2019 21:22
@camden-lunarg
tests: Add test file for BP and move 1 test
e0b726c 
Fix formatting issue

Change-Id: I40d125805b7d41da7a4715e194dbe945e4f91591
@camden-lunarg camden-lunarg merged commit f55721f into master Nov 14, 2019
@camden-lunarg camden-lunarg deleted the camden_BP_issue24_1307 branch November 14, 2019 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mark-lunarg mark-lunarg mark-lunarg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unnecesary warning regarding clearing.
2 participants
@camden-lunarg @mark-lunarg