Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Using the same attachment as a color & input attachment for a subpass triggers questionable warnings #10

Closed
karl-lunarg opened this issue May 14, 2018 · 2 comments
Closed

Using the same attachment as a color & input attachment for a subpass triggers questionable warnings #10

karl-lunarg opened this issue May 14, 2018 · 2 comments
Assignees
@chrisforbes
Labels
Bug Something isn't working
Milestone
sdk-1.1.114.0

Comments

@karl-lunarg
Copy link
Contributor

Issue by DominikWitczakAMD (MIGRATED)
Friday Oct 21, 2016 at 12:08 GMT
Originally opened as KhronosGroup/Vulkan-LoaderAndValidationLayers#1080

Consider an app which uses a renderpass attachment X both as a color & an input attachment in the same subpass. This triggers the following warnings:

image

image

However:

  • The attachment cannot be in COLOR_ATTACHMENT_OPTIMAL layout because that's illegal as per spec.
  • The attachment cannot be in READ_ONLY_OPTIMAL layout because of the same reason.
  • The attachment cannot be in two layouts at once :)
@karl-lunarg karl-lunarg added this to the P2 milestone May 14, 2018
@karl-lunarg karl-lunarg added the Bug Something isn't working label May 14, 2018
@karl-lunarg
Copy link
Contributor Author

Comment by chrisforbes (MIGRATED)
Tuesday Oct 25, 2016 at 08:09 GMT

Yep, that's pretty awful. To do this properly we need to combine all the constraints on the layout, rather than making a fuss about each constraint individually.

@daveh-lunarg daveh-lunarg removed their assignment Jan 21, 2019
@locke-lunarg
Copy link
Contributor

locke-lunarg commented Mar 12, 2019 •
edited
Loading

According to VkLayerTest.InvalidImageLayout, the issue should be resolved.

@shannon-lunarg shannon-lunarg modified the milestones: P2, sdk-1.1.114.0 Jul 24, 2019
AttilioProvenzano-ARM added a commit to ARM-software/Vulkan-ValidationLayers that referenced this issue Feb 27, 2020
@AttilioProvenzano-ARM
practices: Add checks for images and buffers
efd79e5 
This commit adds checks regarding:
 - Store ops for potentially transient images
 - Framebuffer attachments that should/should not be transient
 - Clearing attachments after load
 - Many instanced vertex buffers in a pipeline

This corresponds to checks KhronosGroup#8, KhronosGroup#10-11, KhronosGroup#14 and KhronosGroup#32 from PerfDoc.
AttilioProvenzano-ARM added a commit to ARM-software/Vulkan-ValidationLayers that referenced this issue Feb 27, 2020
@AttilioProvenzano-ARM
practices: Add checks for images and buffers
f0ba635 
This commit adds checks regarding:
 - Store ops for potentially transient images
 - Framebuffer attachments that should/should not be transient
 - Clearing attachments after load
 - Many instanced vertex buffers in a pipeline

This corresponds to checks KhronosGroup#8, KhronosGroup#10-11, KhronosGroup#14 and KhronosGroup#32 from PerfDoc.
AttilioProvenzano-ARM added a commit to ARM-software/Vulkan-ValidationLayers that referenced this issue Feb 27, 2020
@AttilioProvenzano-ARM
practices: Add checks for images and buffers
ccd77aa 
This commit adds checks regarding:
 - Store ops for potentially transient images
 - Framebuffer attachments that should/should not be transient
 - Clearing attachments after load
 - Many instanced vertex buffers in a pipeline

This corresponds to checks KhronosGroup#8, KhronosGroup#10-11, KhronosGroup#14 and KhronosGroup#32 from PerfDoc.
AttilioProvenzano-ARM added a commit to ARM-software/Vulkan-ValidationLayers that referenced this issue Feb 28, 2020
@AttilioProvenzano-ARM
practices: Add checks for images and buffers
43d4ed8 
This commit adds checks regarding:
 - Store ops for potentially transient images
 - Framebuffer attachments that should/should not be transient
 - Clearing attachments after load
 - Many instanced vertex buffers in a pipeline

This corresponds to checks KhronosGroup#8, KhronosGroup#10-11, KhronosGroup#14 and KhronosGroup#32 from PerfDoc.
AttilioProvenzano-ARM added a commit to ARM-software/Vulkan-ValidationLayers that referenced this issue Feb 28, 2020
@AttilioProvenzano-ARM
practices: Add checks for images and buffers
5073ab6 
This commit adds checks regarding:
 - Store ops for potentially transient images
 - Framebuffer attachments that should/should not be transient
 - Clearing attachments after load
 - Many instanced vertex buffers in a pipeline

This corresponds to checks KhronosGroup#8, KhronosGroup#10-11, KhronosGroup#14 and KhronosGroup#32 from PerfDoc.
mark-lunarg pushed a commit that referenced this issue Feb 28, 2020
@AttilioProvenzano-ARM @mark-lunarg
practices: Add checks for images and buffers
1d9a836 
This commit adds checks regarding:
 - Store ops for potentially transient images
 - Framebuffer attachments that should/should not be transient
 - Clearing attachments after load
 - Many instanced vertex buffers in a pipeline

This corresponds to checks #8, #10-11, #14 and #32 from PerfDoc.
This was referenced Jul 9, 2020
Merged
Merged
@mark-lunarg mark-lunarg mentioned this issue Aug 6, 2020
Merged
@jbauman42 jbauman42 mentioned this issue Oct 21, 2022
Closed
@jbauman42 jbauman42 mentioned this issue Nov 18, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chrisforbes chrisforbes

Labels
Bug Something isn't working
Projects
None yet
Milestone
sdk-1.1.114.0
Development

No branches or pull requests
6 participants
@chrisforbes @mark-lunarg @karl-lunarg @daveh-lunarg @shannon-lunarg @locke-lunarg