Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clearly label C vs C++ headers #1

Closed
karl-lunarg opened this issue May 14, 2018 · 3 comments
Closed

Clearly label C vs C++ headers #1

karl-lunarg opened this issue May 14, 2018 · 3 comments
Assignees
@lenny-lunarg
Labels
Enhancement New feature or request
Milestone
sdk-1.1.108.0

Comments

@karl-lunarg
Copy link
Contributor

Issue by Delwin9999 (MIGRATED)
Friday May 06, 2016 at 13:27 GMT
Originally opened as KhronosGroup/Vulkan-LoaderAndValidationLayers#499

Some of this repository is in C, other parts are in C++. There are different headers necessary (inttypes.h vs. cinttypes) depending on what language you are compiling to.

Source files are already labels (.c vs *.cpp). I suggest that headers likewise be labelled (.h vs. *.hpp) whereas currently all headers are *.h.
@karl-lunarg karl-lunarg added this to the P2 milestone May 14, 2018
@karl-lunarg karl-lunarg added the Enhancement New feature or request label May 14, 2018
@karl-lunarg
Copy link
Contributor Author

Comment by lentinem (MIGRATED)
Friday May 06, 2016 at 14:42 GMT

I'm not a fan of the h/hpp separation but I would like to pretty much uniformly make everything C++ over time so keeping this open to track that.

@karl-lunarg
Copy link
Contributor Author

Comment by jon-lunarg (MIGRATED)
Tuesday Jun 14, 2016 at 20:12 GMT

If the loader and the layers no longer share any header files (except vk_layer.h) then we could more easily resolve this issue.

@mark-lunarg mark-lunarg modified the milestones: P2, P3 May 14, 2018
@ericwomer ericwomer mentioned this issue Dec 26, 2018
Closed
@Lunarsong Lunarsong mentioned this issue Feb 11, 2019
Closed
@edrickhong edrickhong mentioned this issue Mar 27, 2019
Closed
@mark-lunarg
Copy link
Contributor

Since this issue was created, the loader-related files have been moved into a separate repository. This should minimize, if not eliminate, uncertainty about the compilation target type.

@reduz reduz mentioned this issue Jul 20, 2019
Closed
@shannon-lunarg shannon-lunarg modified the milestones: P3, sdk-1.1.108.0 Jul 24, 2019
@hysw hysw mentioned this issue Oct 3, 2019
Closed
@kspagnoli kspagnoli mentioned this issue Feb 3, 2020
Closed
@thenegativehunter thenegativehunter mentioned this issue Feb 12, 2020
Closed
AttilioProvenzano-ARM added a commit to ARM-software/Vulkan-ValidationLayers that referenced this issue Feb 27, 2020
@AttilioProvenzano-ARM
practices: Add checks for command buffers
adfbe41 
This commit adds checks for:
 - Command pool creation with the RESET_COMMAND_BUFFER bit
 - Simultaneous use of command buffers

This corresponds to checks KhronosGroup#1-2 from PerfDoc.
AttilioProvenzano-ARM added a commit to ARM-software/Vulkan-ValidationLayers that referenced this issue Feb 27, 2020
@AttilioProvenzano-ARM
practices: Add checks for command buffers
3e639a6 
This commit adds checks for:
 - Command pool creation with the RESET_COMMAND_BUFFER bit
 - Simultaneous use of command buffers

This corresponds to checks KhronosGroup#1-2 from PerfDoc.
AttilioProvenzano-ARM added a commit to ARM-software/Vulkan-ValidationLayers that referenced this issue Feb 27, 2020
@AttilioProvenzano-ARM
practices: Add checks for command buffers
0d04c42 
This commit adds checks for:
 - Command pool creation with the RESET_COMMAND_BUFFER bit
 - Simultaneous use of command buffers

This corresponds to checks KhronosGroup#1-2 from PerfDoc.
AttilioProvenzano-ARM added a commit to ARM-software/Vulkan-ValidationLayers that referenced this issue Feb 27, 2020
@AttilioProvenzano-ARM
practices: Add checks for command buffers
195f3d5 
This commit adds checks for:
 - Command pool creation with the RESET_COMMAND_BUFFER bit
 - Simultaneous use of command buffers

This corresponds to checks KhronosGroup#1-2 from PerfDoc.
mark-lunarg pushed a commit that referenced this issue Feb 27, 2020
@AttilioProvenzano-ARM @mark-lunarg
practices: Add checks for command buffers
746e43e 
This commit adds checks for:
 - Command pool creation with the RESET_COMMAND_BUFFER bit
 - Simultaneous use of command buffers

This corresponds to checks #1-2 from PerfDoc.
@Jasper-Bekkers Jasper-Bekkers mentioned this issue Apr 8, 2020
Closed
This was referenced Jul 9, 2020
Merged
Merged
@danielmaciel danielmaciel mentioned this issue Jul 25, 2020
Closed
@mark-lunarg mark-lunarg mentioned this issue Aug 6, 2020
Merged
@mark-lunarg mark-lunarg mentioned this issue Aug 28, 2020
Closed
@snowman791 snowman791 mentioned this issue Oct 20, 2020
Closed
lunarpapillo added a commit that referenced this issue Apr 17, 2021
@lunarpapillo
docs: bob-test-push #1
6c95bc4
@y-novikov y-novikov mentioned this issue May 21, 2021
Closed
@nisse-work nisse-work mentioned this issue Jul 12, 2021
Closed
@mark-lunarg mark-lunarg mentioned this issue Aug 31, 2021
Closed
@Cvostr Cvostr mentioned this issue Sep 16, 2021
Closed
AaronHaganAMD added a commit to AaronHaganAMD/Vulkan-ValidationLayers that referenced this issue Nov 16, 2021
@AaronHaganAMD
layers: Add VK_KHR_dynamic_rendering VUs - Change Set KhronosGroup#1
de23bae 
Add additional VUs for the VK_KHR_dynamic_rendering extension.
VUIDs for VkRenderingFragmentShadingRateAttachmentInfoKHR, VkRenderingAttachmentInfoKHR
VkCommandBufferBeginInfo, and VkCommandBufferInheritanceRenderingInfoKHR

VUID-06449
VUID-06124
VUID-06125
VUID-06147
VUID-06149
VUID-06150
VUID-06151
VUID-06152
VUID-06153
VUID-06154
VUID-06155
VUID-06156
VUID-06116
VUID-06143
VUID-06140
VUID-06144
VUID-06141
VUID-06142
VUID-06001
VUID-06003
VUID-06003
VUID-06006
VUID-06007
VUID-06199
VUID-06200
VUID-06008
VUID-06009
AaronHaganAMD added a commit to AaronHaganAMD/Vulkan-ValidationLayers that referenced this issue Nov 16, 2021
@AaronHaganAMD
layers: Add VK_KHR_dynamic_rendering VUs - Change Set KhronosGroup#1
5c116d2 
Add additional VUs for the VK_KHR_dynamic_rendering extension.
VUIDs for VkRenderingFragmentShadingRateAttachmentInfoKHR,
VkRenderingAttachmentInfoKHR VkCommandBufferBeginInfo, and
VkCommandBufferInheritanceRenderingInfoKHR

VUID-06449
VUID-06124
VUID-06125
VUID-06147
VUID-06149
VUID-06150
VUID-06151
VUID-06152
VUID-06153
VUID-06154
VUID-06155
VUID-06156
VUID-06116
VUID-06143
VUID-06140
VUID-06144
VUID-06141
VUID-06142
VUID-06001
VUID-06003
VUID-06003
VUID-06006
VUID-06007
VUID-06199
VUID-06200
VUID-06008
VUID-06009
jeremyg-lunarg pushed a commit that referenced this issue Nov 16, 2021
@AaronHaganAMD @jeremyg-lunarg
layers: Add VK_KHR_dynamic_rendering VUs - Change Set #1
0137092 
Add additional VUs for the VK_KHR_dynamic_rendering extension.
VUIDs for VkRenderingFragmentShadingRateAttachmentInfoKHR,
VkRenderingAttachmentInfoKHR VkCommandBufferBeginInfo, and
VkCommandBufferInheritanceRenderingInfoKHR

VUID-06449
VUID-06124
VUID-06125
VUID-06147
VUID-06149
VUID-06150
VUID-06151
VUID-06152
VUID-06153
VUID-06154
VUID-06155
VUID-06156
VUID-06116
VUID-06143
VUID-06140
VUID-06144
VUID-06141
VUID-06142
VUID-06001
VUID-06003
VUID-06003
VUID-06006
VUID-06007
VUID-06199
VUID-06200
VUID-06008
VUID-06009
@farnoy farnoy mentioned this issue Dec 9, 2021
Closed
@jeremyg-lunarg jeremyg-lunarg mentioned this issue Jan 14, 2022
Merged
@austinEng austinEng mentioned this issue Mar 30, 2022
Closed
@rikusalminen rikusalminen mentioned this issue Apr 22, 2022
Closed
@jbauman42 jbauman42 mentioned this issue Oct 21, 2022
Closed
@juan-lunarg juan-lunarg mentioned this issue Nov 10, 2022
Merged
@jbauman42 jbauman42 mentioned this issue Nov 18, 2022
Closed
@haasn haasn mentioned this issue Jan 4, 2023
Closed
@haasn haasn mentioned this issue Dec 6, 2023
Closed
@haasn haasn mentioned this issue Feb 19, 2024
Closed
@Goshido Goshido mentioned this issue Mar 5, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lenny-lunarg lenny-lunarg

Labels
Enhancement New feature or request
Projects
None yet
Milestone
sdk-1.1.108.0
Development

No branches or pull requests
4 participants
@mark-lunarg @karl-lunarg @lenny-lunarg @shannon-lunarg