Skip to content

Commit

Permalink
tests: Fix VUID-07908 tests
Browse files Browse the repository at this point in the history
Remove VUID-07908 from
NegativeDynamicRendering.RenderingFragmentDensityMapAttachment
Account for VUID-07908 changes in
NegativeDynamicRendering.FragmentDensityMapAttachmentLayerCount
  • Loading branch information
aitor-lunarg committed Nov 13, 2023
1 parent 9b009b8 commit 327fedb
Showing 1 changed file with 5 additions and 3 deletions.
8 changes: 5 additions & 3 deletions tests/unit/dynamic_rendering.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -3598,7 +3598,6 @@ TEST_F(NegativeDynamicRendering, RenderingFragmentDensityMapAttachment) {
VkImageView image_view2 = image2.targetView(VK_FORMAT_R8G8B8A8_UNORM, VK_IMAGE_ASPECT_COLOR_BIT, 0, VK_REMAINING_MIP_LEVELS, 0,
VK_REMAINING_ARRAY_LAYERS, VK_IMAGE_VIEW_TYPE_2D_ARRAY);
rendering_fragment_density.imageView = image_view2;
m_errorMonitor->SetDesiredFailureMsg(kErrorBit, "VUID-VkRenderingFragmentDensityMapAttachmentInfoEXT-apiVersion-07908");
m_errorMonitor->SetDesiredFailureMsg(kErrorBit, "VUID-VkRenderingInfo-imageView-06109");
m_commandBuffer->BeginRendering(begin_rendering_info);
m_errorMonitor->VerifyFound();
Expand Down Expand Up @@ -3680,8 +3679,11 @@ TEST_F(NegativeDynamicRendering, FragmentDensityMapAttachmentLayerCount) {
VK_FORMAT_FEATURE_FRAGMENT_DENSITY_MAP_BIT_EXT)) {
GTEST_SKIP() << "VK_FORMAT_FEATURE_FRAGMENT_DENSITY_MAP_BIT_EXT not supported";
}
if (!multiview_features.multiview) {
GTEST_SKIP() << "Test requires (unsupported) multiview";
if (multiview_features.multiview || physDevProps.apiVersion >= VK_API_VERSION_1_1) {
auto mayor_version = VK_API_VERSION_MAJOR(physDevProps.apiVersion);
auto minor_version = VK_API_VERSION_MINOR(physDevProps.apiVersion);
GTEST_SKIP() << "Test requires multiview to be unsupported (" << multiview_features.multiview
<< ") or physical device's api version (" << mayor_version << "." << minor_version << ") to be less than 1.1";
}

InitRenderTarget();
Expand Down

0 comments on commit 327fedb

Please sign in to comment.