Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix automated builds #296

Merged
merged 2 commits into from
Oct 24, 2024
Merged

fix automated builds #296

merged 2 commits into from
Oct 24, 2024

Conversation

bashbaug
Copy link
Collaborator

Copy link
Contributor

@dgkoch dgkoch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sees to work, so LGTM. I don't really understand which piece fixes it though.

@bashbaug
Copy link
Collaborator Author

I think it's due to the change from pull_request_target to pull_request. See:
https://docs.github.com/en/actions/writing-workflows/choosing-when-your-workflow-runs/events-that-trigger-workflows#pull_request_target

"This event runs in the context of the base of the pull request, rather than in the context of the merge commit, as the pull_request event does."

@dgkoch
Copy link
Contributor

dgkoch commented Oct 23, 2024

Ah - gotcha. That makes sense.

Copy link
Member

@Naghasan Naghasan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Naghasan Naghasan merged commit d3d87ea into KhronosGroup:main Oct 24, 2024
1 of 2 checks passed
@bashbaug bashbaug deleted the automation-fixes branch October 24, 2024 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants