Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build failure for QCOM extensions #295

Closed
wants to merge 1 commit into from
Closed

Fix build failure for QCOM extensions #295

wants to merge 1 commit into from

Conversation

dgkoch
Copy link
Contributor

@dgkoch dgkoch commented Oct 23, 2024

Includes fixes from #294 (to be able to test CI)

@bashbaug
Copy link
Collaborator

Hmm, seems like the automated builds are always pulling from the main branch, even for PRs. I see:

Checking out the ref
  /usr/bin/git checkout --progress --force -B main refs/remotes/origin/main
  Switched to a new branch 'main'
  branch 'main' set up to track 'origin/main'.
/usr/bin/git log -1 --format='%H'
'd33d158f9df194a004c5104ce89699fedf78cf1f'

@dgkoch
Copy link
Contributor Author

dgkoch commented Oct 23, 2024

Hmm, seems like the automated builds are always pulling from the main branch, even for PRs. I see:

Yes - I noticed that on the last PR as well. I haven't been able to figure out why yet.. (and I've been comparing vs other repos that I know work correctly).

Maybe @llvm-beanz knows?

@bashbaug bashbaug mentioned this pull request Oct 23, 2024
@bashbaug
Copy link
Collaborator

Have a look at #296 - it changes the automated builds slightly and appears to be building from the correct branch now, and includes these asciidoc fixes.

@dgkoch
Copy link
Contributor Author

dgkoch commented Oct 23, 2024

Have a look at #296 - it changes the automated builds slightly and appears to be building from the correct branch now, and includes these asciidoc fixes.

Well it appears to work correctly. I don't understand what is substantively different about it though...

@Naghasan
Copy link
Member

Closing as it is superseded by #296

@Naghasan Naghasan closed this Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants