[Backport to 12] Support SPV_INTEL_maximum_registers extension (#2344) #2400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vmaksimo
reviewed
Mar 14, 2024
| @@ -55,7 +55,7 @@ using namespace spv; | |||
| namespace SPIRV { | |||
|
|
|||
| inline bool isValid(spv::ExecutionModel V) { | |||
| switch (V) { | |||
| switch (static_cast<uint32_t>(V)) { | |||
There was a problem hiding this comment.
My guess is that cast is not needed because we don't have "internal" values as in newer release branches. Could you please check?
There was a problem hiding this comment.
"Out-of-tree" builds are broken without this cast.
There was a problem hiding this comment.
Oh, that's my bad, didn't expect this. Please return the cast and we'll merge the change
This reverts commit b9c9b67.
vmaksimo
approved these changes
Mar 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Spec:
KhronosGroup/SPIRV-Registry#235