Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use fp_fast_mode extension with the capability #2028

Merged

Conversation

pjaaskel
Copy link

No description provided.

@CLAassistant
Copy link

CLAassistant commented May 29, 2023

CLA assistant check
All committers have signed the CLA.

@MrSidims
Copy link
Contributor

MrSidims commented May 30, 2023

@pjaaskel hi, I'd suggest not to include clang-format changes in this patch outside of a scope modified lines of code
upd: mmm, actually, there are not so many clang-format changes, so lgtm

btw, do you plan to add this patch to main branch as well?

@pjaaskel
Copy link
Author

@pjaaskel hi, I'd suggest not to include clang-format changes in this patch outside of a scope modified lines of code upd: mmm, actually, there are not so many clang-format changes, so lgtm

OK, won't do that in the future.

btw, do you plan to add this patch to main branch as well?

We have no immediate plans as we typically port CHIP-SPV to LLVM release branches only. I'd appreciate if someone forward ported this who is working with main.

@MrSidims
Copy link
Contributor

I'll take care of the cherry-pick, no problem

@MrSidims MrSidims merged commit 17cfdbd into KhronosGroup:llvm_release_160 May 31, 2023
@pjaaskel
Copy link
Author

I'll take care of the cherry-pick, no problem

Thanks!

franz pushed a commit to CHIP-SPV/SPIRV-LLVM-Translator that referenced this pull request Aug 1, 2023
franz pushed a commit to CHIP-SPV/SPIRV-LLVM-Translator that referenced this pull request Aug 25, 2023
franz pushed a commit to franz/SPIRV-LLVM-Translator that referenced this pull request Nov 27, 2023
franz pushed a commit to franz/SPIRV-LLVM-Translator that referenced this pull request Jan 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants