Support system libs better #141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Needed for upcoming change.
rpavlik
force-pushed
the
jsoncpp-optional
branch
from
87f73e4 to
56e1a44
Compare
They might be dropped form distro source packages since they're duplicates.
rpavlik
force-pushed
the
jsoncpp-optional
branch
from
56e1a44 to
597026d
Compare
rpavlik
added a commit
that referenced
this pull request
Nov 22, 2019
Patch release for the 1.0 series. This release includes some fixes, extensions, and a small build system change: the build system is now configured to use C++14. No code changes in the loader or layers have yet taken place that require C++14. **Please file an issue** in OpenXR-SDK-Source if there is some deployment platform where you would be unable to use a loader making use of C++14 features. ### GitHub Pull Requests These had been integrated into the public repo incrementally. - General, Build, Other - #141 - Support system libs better (permit system jsoncpp, etc. for easier packaging) - hello_xr - #144 - Fix hello_xr when running under Linux OpenGL X11 - Registry - Reserve a Monado EGL extension <KhronosGroup/OpenXR-Docs#39> ### Internal issues - General, Build, Other - Switch C++ standard version to C++14 (internal MR 1602) - Remove unused/unneeded files (internal MR 1609) - Loader - Fix typo in parameter/member names (internal MR 1607, internal issue 1233) - Fix deprecated usage of JsonCpp (internal MR 1604, internal issue 1212) - hello_xr - Resolve misleading use of `xrLocateViews` before `xrWaitFrame` in helloXR and spec (internal MR 1584, internal issue 1227, public issue <#134>) - Registry - Add `XR_EXT_conformance_automation` extension, for use **only** by conformance testing (internal MR 1577, 1608)
rhabacker
pushed a commit
to rhabacker/OpenXR-SDK-Source
that referenced
this pull request
Nov 16, 2022
Patch release for the 1.0 series. This release includes some fixes, extensions, and a small build system change: the build system is now configured to use C++14. No code changes in the loader or layers have yet taken place that require C++14. **Please file an issue** in OpenXR-SDK-Source if there is some deployment platform where you would be unable to use a loader making use of C++14 features. ### GitHub Pull Requests These had been integrated into the public repo incrementally. - General, Build, Other - KhronosGroup#141 - Support system libs better (permit system jsoncpp, etc. for easier packaging) - hello_xr - KhronosGroup#144 - Fix hello_xr when running under Linux OpenGL X11 - Registry - Reserve a Monado EGL extension <KhronosGroup/OpenXR-Docs#39> ### Internal issues - General, Build, Other - Switch C++ standard version to C++14 (internal MR 1602) - Remove unused/unneeded files (internal MR 1609) - Loader - Fix typo in parameter/member names (internal MR 1607, internal issue 1233) - Fix deprecated usage of JsonCpp (internal MR 1604, internal issue 1212) - hello_xr - Resolve misleading use of `xrLocateViews` before `xrWaitFrame` in helloXR and spec (internal MR 1584, internal issue 1227, public issue <KhronosGroup#134>) - Registry - Add `XR_EXT_conformance_automation` extension, for use **only** by conformance testing (internal MR 1577, 1608)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it possible to build against system jsoncpp. Required for some packaging.
It also makes it possible to drop the wglext.h and glext.h headers from the source package if, for instance, you're on a platform that has those headers system-installed and you don't want to duplicate things...
With these patches, if your distribution requires it, you may drop the following files/directories from the source tree and, as long as you have the associated deps system-installed, still succeed in building:
external/include/GL/wglext.hexternal/include/GL/glext.hexternal/pythonexternal/libs(I suspect this is entirely unused...)src/external/jsoncppspecification/scripts/katex(I think not needed anywhere)specification/scripts/htmldiff(only needed on docs repos, I think)