Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Misleading use of xrLocateViews before xrWaitFrame in spec example #134

Closed
Sgeo opened this issue Sep 16, 2019 · 3 comments
Closed

Misleading use of xrLocateViews before xrWaitFrame in spec example #134

Sgeo opened this issue Sep 16, 2019 · 3 comments

Comments

@Sgeo
Copy link

Sgeo commented Sep 16, 2019

In https://www.khronos.org/registry/OpenXR/specs/1.0/html/xrspec.html#example_view_configurations_code, the sample code shows an XrTime displayTime assumed to be previously initialized, then uses xrLocateViews before xrWaitFrame, even though if I understand correctly, xrWaitFrame should be used to initialize displayTime
@yl-msft
Copy link
Contributor

yl-msft commented Sep 20, 2019

Created internal issue #1227 to track this and find solution with working group.

@Sgeo
Copy link
Author

Sgeo commented Sep 21, 2019

I'm not sure if this should get its own ticket, but in the same sample code, there's an initialization XrViewState viewState{};, which is incorrect: It should be XrViewState viewState{XR_TYPE_VIEW_STATE};

rpavlik added a commit to KhronosGroup/OpenXR-Docs that referenced this issue Nov 22, 2019
@rpavlik
OpenXR 1.0.4 release (21-November-2019)
2972361 
Patch release for the 1.0 series.

Updates version to 1.0.4.

### GitHub Pull Requests

- Spec
  - Clarify Monado headless extension behavior related to `xrWaitFrame`
    <#38>
- Registry
  - Reserve a Monado EGL extension
    <#39>

### Internal issues

- General, Build, Other
  - Remove unused/unneeded files (internal MR 1609)
- Spec
  - Clarify subaction path description for XrActiveActionSet (internal MR 1592,
    internal issues 1243 and 1244)
  - Resolve misleading use of `xrLocateViews` before `xrWaitFrame` in helloXR
    and spec (internal MR 1584, internal issue 1227, public issue
    <KhronosGroup/OpenXR-SDK-Source#134>)
- Registry
  - Add `XR_EXT_conformance_automation` extension, for use **only** by
    conformance testing (internal MR 1577, 1608)
rpavlik added a commit that referenced this issue Nov 22, 2019
@rpavlik
OpenXR 1.0.4 release (21-November-2019)
9b9f2e4 
Patch release for the 1.0 series.

This release includes some fixes, extensions, and a small build system change:
the build system is now configured to use C++14. No code changes in the loader
or layers have yet taken place that require C++14. **Please file an issue** in
OpenXR-SDK-Source if there is some deployment platform where you would be unable
to use a loader making use of C++14 features.

### GitHub Pull Requests

These had been integrated into the public repo incrementally.

- General, Build, Other
  - #141 - Support system libs better (permit system jsoncpp, etc. for easier
    packaging)
- hello_xr
  - #144 - Fix hello_xr when running under Linux OpenGL X11
- Registry
  - Reserve a Monado EGL extension
    <KhronosGroup/OpenXR-Docs#39>

### Internal issues

- General, Build, Other
  - Switch C++ standard version to C++14 (internal MR 1602)
  - Remove unused/unneeded files (internal MR 1609)
- Loader
  - Fix typo in parameter/member names (internal MR 1607, internal issue 1233)
  - Fix deprecated usage of JsonCpp (internal MR 1604, internal issue 1212)
- hello_xr
  - Resolve misleading use of `xrLocateViews` before `xrWaitFrame` in helloXR
    and spec (internal MR 1584, internal issue 1227, public issue
    <#134>)
- Registry
  - Add `XR_EXT_conformance_automation` extension, for use **only** by
    conformance testing (internal MR 1577, 1608)
rpavlik added a commit to KhronosGroup/OpenXR-SDK that referenced this issue Nov 22, 2019
@rpavlik
OpenXR 1.0.4 release (21-November-2019)
7462cda 
Patch release for the 1.0 series.

This release includes some fixes, extensions, and a small build system change:
the build system is now configured to use C++14. No code changes in the loader
or layers have yet taken place that require C++14. **Please file an issue** in
OpenXR-SDK-Source if there is some deployment platform where you would be unable
to use a loader making use of C++14 features.

### GitHub Pull Requests

These had been integrated into the public repo incrementally.

- General, Build, Other
  - #141 - Support system libs better (permit system jsoncpp, etc. for easier
    packaging)
- hello_xr
  - #144 - Fix hello_xr when running under Linux OpenGL X11
- Registry
  - Reserve a Monado EGL extension
    <KhronosGroup/OpenXR-Docs#39>

### Internal issues

- General, Build, Other
  - Switch C++ standard version to C++14 (internal MR 1602)
  - Remove unused/unneeded files (internal MR 1609)
- Loader
  - Fix typo in parameter/member names (internal MR 1607, internal issue 1233)
  - Fix deprecated usage of JsonCpp (internal MR 1604, internal issue 1212)
- hello_xr
  - Resolve misleading use of `xrLocateViews` before `xrWaitFrame` in helloXR
    and spec (internal MR 1584, internal issue 1227, public issue
    <KhronosGroup/OpenXR-SDK-Source#134>)
- Registry
  - Add `XR_EXT_conformance_automation` extension, for use **only** by
    conformance testing (internal MR 1577, 1608)
rpavlik added a commit to KhronosGroup/OpenXR-Registry that referenced this issue Nov 22, 2019
@rpavlik
OpenXR 1.0.4 release (21-November-2019)
7fe9353 
Patch release for the 1.0 series.

Updates version to 1.0.4.

### GitHub Pull Requests

- Spec
  - Clarify Monado headless extension behavior related to `xrWaitFrame`
    <KhronosGroup/OpenXR-Docs#38>
- Registry
  - Reserve a Monado EGL extension
    <KhronosGroup/OpenXR-Docs#39>

### Internal issues

- General, Build, Other
  - Remove unused/unneeded files (internal MR 1609)
- Spec
  - Clarify subaction path description for XrActiveActionSet (internal MR 1592,
    internal issues 1243 and 1244)
  - Resolve misleading use of `xrLocateViews` before `xrWaitFrame` in helloXR
    and spec (internal MR 1584, internal issue 1227, public issue
    <KhronosGroup/OpenXR-SDK-Source#134>)
- Registry
  - Add `XR_EXT_conformance_automation` extension, for use **only** by
    conformance testing (internal MR 1577, 1608)
@rpavlik
Copy link
Contributor

rpavlik commented Nov 22, 2019

This is resolved in 1.0.4

@rpavlik rpavlik closed this as completed Nov 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@rpavlik @Sgeo @yl-msft