Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inventory list initial version #56

Merged
merged 164 commits into from
Mar 5, 2024
Merged

Conversation

snipercup
Copy link
Collaborator

This requires #55 to work. I will publish this PR as a draft to make sure #55 gets merged first.

This replaces the current inventory list (provided by Gloot) with a custom inventory list. There is no inventory interaction possible yet, but that will come in a future PR.

  • Based on a GridContainer and is able to show multiple columns like weight and value
  • Can select one or more items from the list using CTRL-selection and SHIFT-selection
  • Can sort the columns by clicking on one of the columns
  • Can right-click on an item and it will show a context menu with item actions (no actions are implemented yet)
    image

I tried to make it work with a ItemList, but you cannot have different sizes per column. I could do something with 5 ItemLists (1 per column), but then we would not have as much control over each item as we do now. I do feel like there is some code that seems like a hack but it works.

In the future I want to add hotkeys to the context menu, or even having hotkeys replace the context menu

When the materials are generated, set the proper uv scaling so they are correctly visualized in-game.
This fixes the situation where if two map editors are opened, only the last one receives input from the scroll wheel
Improved saving loading, added duplicate and delete buttons, icons
Add name and description labels to show info on a tile
Overmap chunks will stay consistent even after changing scenes.
@snipercup snipercup marked this pull request as ready for review March 5, 2024 15:53
@snipercup snipercup merged commit 1a84ea9 into Khaligufzel:main Mar 5, 2024
@snipercup snipercup deleted the Inventory-list branch March 5, 2024 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant