Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #37018 - Use correct function signature for fetchBulkParams #10830

Merged
merged 1 commit into from
Jan 8, 2024

Conversation

jeremylenz
Copy link
Member

In #10783, the fetchBulkParams method was removed from Katello.

In theforeman/foreman#9860, it was moved to Foreman.

In the course of doing so, the function signature was changed from

const fetchBulkParams = (idColumnName = idColumn) => {

to

const fetchBulkParams = ({
    idColumnName = idColumn,
    selectAllQuery = '',
  }) => {

This means that you now have to pass an object instead of a string. This breaks bulk repository set overrides in the web UI.

What are the changes introduced in this pull request?

  • Correctly pass an object to fetchBulkParams

Considerations taken when implementing this change?

What are the testing steps for this pull request?

@jeremylenz jeremylenz marked this pull request as ready for review January 2, 2024 15:38
@jeremylenz jeremylenz requested a review from parthaa January 8, 2024 17:55
Copy link
Contributor

@parthaa parthaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couldn't find other places that were impacted by the fetchBulkParams signature change.
Works well ACK

@jeremylenz jeremylenz merged commit 2ffd146 into Katello:master Jan 8, 2024
6 checks passed
ianballou pushed a commit to ianballou/katello that referenced this pull request Feb 16, 2024
ianballou pushed a commit that referenced this pull request Feb 27, 2024
sbernhard pushed a commit to ATIX-AG/katello that referenced this pull request Feb 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants