Fixes #36866 - Remove table hooks from katello and use foreman #10783
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parthaa
force-pushed
the
byebye-table-hooks
branch
2 times, most recently
from
4525579 to
38cfd27
Compare
|
@parthaa Do we know if Foreman TableHooks has diverged at all from Katello? |
|
@jeremylenz do you mind reviewing the code, while I test the pages to make sure there are not any breakages? |
jeremylenz
reviewed
Nov 1, 2023
| @@ -228,7 +229,7 @@ export const ErrataTab = () => { | |||
| }); | |||
|
|
|||
| const installErrataAction = () => installErrata({ | |||
| hostname, search: fetchBulkParams(), | |||
| hostname, search: fetchBulkParams({}), | |||
There was a problem hiding this comment.
The need to pass {} here is eliminated in theforeman/foreman#9878, but I suppose it's harmless either way. If that gets merged first, you could remove all of these.
There was a problem hiding this comment.
Agreed!. May be I should wait for your PR before merging
|
@sjha4 said he would test the CV pages, working on testing the other stuff that was changed |
sjha4
approved these changes
Nov 2, 2023
chris1984
approved these changes
Nov 2, 2023
1 task
parthaa
force-pushed
the
byebye-table-hooks
branch
from
38cfd27 to
5b8ce0d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the changes introduced in this pull request?
Now that TableHooks.js code has been ported to Foreman, we need to have Katello consume it from there so code isn't duplicated. This PR does the clean up / walden job
What are the testing steps for this pull request?