Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase timeout for info functions .*smoke.* gdb command #308

Merged
merged 2 commits into from
Jan 21, 2025

Conversation

zakkak
Copy link
Collaborator

@zakkak zakkak commented Jan 20, 2025

GDB appears to take longer to load symbols in graal/master builds than
it used to in 24.1.1.

24.1.1

gdb -q target/debug-symbols-smoke < gdb.commands  2.27s user 0.06s system 101% cpu 2.288 total

graalm/master

gdb -q target/debug-symbols-smoke < gdb.commands  3.01s user 0.05s system 102% cpu 2.995 total

@jerboaa
Copy link
Collaborator

jerboaa commented Jan 20, 2025

CI fails on windows with:

Error:  Failures: 
Error:    AppReproducersTest.jdkReflectionsTest:871->jdkReflections:902 build.log log should not contain error or warning lines that are not whitelisted. See D:\a\mandrel-integration-tests\mandrel-integration-tests\ts\testsuite\target\archived-logs\org.graalvm.tests.integration.AppReproducersTest\jdkReflectionsTest\build.log and check these offending lines: 
The build process encountered an unexpected error:
If you are unable to resolve this problem, please file an issue with the error report at:
jdkreflections.obj : error LNK2001: unresolved external symbol Java_java_lang_Thread_getNextThreadIdOffset
D:\a\mandrel-integration-tests\mandrel-integration-tests\ts\apps\jdkreflections\target\jdkreflections.exe : fatal error LNK1120: 1 unresolved externals
Please inspect the generated error report at:
> java.lang.RuntimeException: There was an error linking the native image: Linker command exited with 2 ==> expected: <true> but was: <false>

Somebody will need to investigate.
Example: https://github.com/Karm/mandrel-integration-tests/actions/runs/12864812401/job/35864082207?pr=308#step:7:14889

@jerboaa
Copy link
Collaborator

jerboaa commented Jan 20, 2025

I'm OK with this work-around, but please file an issue to better investigate why this is happening now. That issue could very well be closed as won't fix or this workaround be reverted with a better fix. Either way, we should have a record of it. Thanks!

@zakkak
Copy link
Collaborator Author

zakkak commented Jan 20, 2025

Upstream issue: oracle/graal#10512

@jerboaa
Copy link
Collaborator

jerboaa commented Jan 20, 2025

CI fails on windows with:

Error:  Failures: 
Error:    AppReproducersTest.jdkReflectionsTest:871->jdkReflections:902 build.log log should not contain error or warning lines that are not whitelisted. See D:\a\mandrel-integration-tests\mandrel-integration-tests\ts\testsuite\target\archived-logs\org.graalvm.tests.integration.AppReproducersTest\jdkReflectionsTest\build.log and check these offending lines: 
The build process encountered an unexpected error:
If you are unable to resolve this problem, please file an issue with the error report at:
jdkreflections.obj : error LNK2001: unresolved external symbol Java_java_lang_Thread_getNextThreadIdOffset
D:\a\mandrel-integration-tests\mandrel-integration-tests\ts\apps\jdkreflections\target\jdkreflections.exe : fatal error LNK1120: 1 unresolved externals
Please inspect the generated error report at:
> java.lang.RuntimeException: There was an error linking the native image: Linker command exited with 2 ==> expected: <true> but was: <false>

Somebody will need to investigate. Example: https://github.com/Karm/mandrel-integration-tests/actions/runs/12864812401/job/35864082207?pr=308#step:7:14889

OK, fails on Linux too and is related to a new integration test (PR #306) that got introduced recently. The test bug is that this test runs even though it's supposed to get skipped on Mandrel 23.1.x for any x lower than 6.

GDB appears to take longer to load symbols in `graal/master` builds than
it used to in 24.1.1.

24.1.1
```
gdb -q target/debug-symbols-smoke < gdb.commands  2.27s user 0.06s system 101% cpu 2.288 total
```

`graalm/master`
```
gdb -q target/debug-symbols-smoke < gdb.commands  3.01s user 0.05s system 102% cpu 2.995 total
```
@zakkak zakkak force-pushed the 2025-01-20-increase-timeout branch from fa27154 to 4aeff96 Compare January 21, 2025 13:47
@zakkak zakkak merged commit a8dd3d3 into Karm:master Jan 21, 2025
0 of 27 checks passed
@zakkak zakkak deleted the 2025-01-20-increase-timeout branch January 21, 2025 13:51
zakkak added a commit to zakkak/mandrel-integration-tests that referenced this pull request Jan 22, 2025
Place the increased timeout in the correct if statement.
zakkak added a commit that referenced this pull request Jan 22, 2025
Place the increased timeout in the correct if statement.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants