-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tests graalvm-community-jdk21u-issues-28 #306
Conversation
Hmm, it worries me that all tests in CI passes. JDK 21 should have failed. Lemme take a look... |
You set
I suggest bumping both the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, other than the minJDK
version being 21.0.3
while the test is expected to fail with any JDK 21 build.
testsuite/src/it/java/org/graalvm/tests/integration/AppReproducersTest.java
Outdated
Show resolved
Hide resolved
testsuite/src/it/java/org/graalvm/tests/integration/AppReproducersTest.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK (with the suggestions from @zakkak)
Embeds a variation on the reproducer @zakkak outlined on the original issue.
This forces the native agent to register e.g. the
getNextThreadIdOffset
that later causesFails with current Mandrel for JDK 21, passes with e.g. Mandrel for JDK 23.
or in a container:
...swap jdk-23 with jdk-21 to see the fail.