chore(storybook): re-enable for pull requests #1805
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1805 +/- ##
==========================================
+ Coverage 65.73% 65.76% +0.02%
==========================================
Files 74 74
Lines 2212 2211 -1
Branches 512 514 +2
==========================================
Hits 1454 1454
+ Misses 710 709 -1
Partials 48 48
|
| @@ -1 +1,2 @@ | |||
| CHROMATIC_PROJECT_TOKEN=14f589a59855 | |||
There was a problem hiding this comment.
Although is not ideal, we agreed on having this token shared among contributors to allow pull request checks from forks.
|
|
||
| const foreignObjectSize = 40; | ||
|
|
||
| export interface IPlusButtonEdge { | ||
| data?: any; | ||
| data?: { |
There was a problem hiding this comment.
[curious-question]: What should be the right type for this component? I couldn't find a type combining showBranchesTab and sourceStepNode 🤔
There was a problem hiding this comment.
fix(storybook): fix typescript ide errors chore(storybook): migrate to Meta, StoryFn
…move biz logic out fix(test): fix edge tests for updated data structure fix: fix issue with plus button edge update yarn.lock minor changes chore: rebase chore: rebase add storybook-static to gitignore
|
Kudos, SonarCloud Quality Gate passed!
|
|
E2E tests are being flaky again, particularly for Chrome and Edge :( |
This PR adds support for building stories on pull requests to
kaoto-uifrom any fork or branch, excluding Dependabot PRs.Resolves #1100
Storybook no longer provides its own Babel configuration, so we have had to introduce it. This should not cause build issues as we are using Webpack and
ts-loaderfor transpilation for the project.Follow-up PR will include Storybook MSW add-on for mocking network requests.