You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Nov 27, 2023. It is now read-only.
Add MSW to mock network requests where necessary (see Add mocking for testing #1258, hopefully we can use this mocking for both types of tests)
Add stories for components
Add documentation for components, where possible
Update relevant API keys where necessary
Ensure Storybook stories are run on each PR
Test the stories, whether through React Testing Library or Cypress component testing TBD, might add too much overhead
Tests should only be run against the main branch and primary repo, not for forks. This could be good to do once #1183 and other refactoring of stateful components is done.
The text was updated successfully, but these errors were encountered:
@igarashitm - Originally I wanted to wait to have this once we refactored the UI components into stateless components, but I think it would be good to already start building them again and creating basic stories and docs for the components like this: https://storybook.js.org/addons/@storybook/addon-docs
What do you think? Or wait until the refactor (depending what kind of refactoring you decide to do)? I wouldn't start on this right away but at the end of next week if I finished visual branching and e2e tests in time.
Please describe the task that needs to be done
We should look to re-enable Storybook to continue to ensure that our code base has the separation of concerns for visual components.
Test the stories, whether through React Testing Library or Cypress component testingTBD, might add too much overheadTests should only be run against the
main
branch and primary repo, not for forks. This could be good to do once #1183 and other refactoring of stateful components is done.The text was updated successfully, but these errors were encountered: