Skip to content
This repository has been archived by the owner on Nov 27, 2023. It is now read-only.

Refactor: Investigate any better way for managing services lifecycle #1233

Open
igarashitm opened this issue Feb 10, 2023 · 1 comment
Open
Labels
chore Tests, CI/CD, general maintenance enhancement Improve existing features

Comments

@igarashitm
Copy link
Contributor

Please describe the task that needs to be done

As a part of #1183 work, #1228 is turning services into class, and components are going to instantiate them like this
b394613#diff-b05d69f0aef9ae8d739a7510b44be6747508e1709033a2e44f609523c404f5fcR46

One concern here is the instantiation happens on every rerendering, on every component. It might cause performance degradation. Investigate if there's any better way. Possible option is context/provider pattern.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
chore Tests, CI/CD, general maintenance enhancement Improve existing features
Projects
None yet
Development

No branches or pull requests

2 participants