This repository has been archived by the owner on Nov 27, 2023. It is now read-only.
chore: re-enable storybook, add support for mocking #1579
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chore(storybook): add msw for network mocking in stories chore: update main.js
|
Kudos, SonarCloud Quality Gate passed!
|
Codecov Report
@@ Coverage Diff @@
## main #1579 +/- ##
=======================================
Coverage 57.00% 57.00%
=======================================
Files 68 68
Lines 2056 2056
Branches 470 470
=======================================
Hits 1172 1172
Misses 840 840
Partials 44 44 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds msw, sets up mocking for Storybook, and sets up an example call. It only mocks one endpoint as an example so that we can continue to work on this once 1.0 is released. It also re-enables Storybook, fixing an issue with private classes. Relates to #1100 and #1258 , but doesn't close them.
Please let me know if you'd rather calls be mocked using JS/TS instead of JSON. I chose JSON since it's what the API returns and is the fastest performance-wise, but I don't have a strong opinion about this.
Storybook Catalog story: