Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cxx-qt-gen: use namespace for internal methods and support no namespace #210

Merged
merged 2 commits into from
Aug 12, 2022

Conversation

ahayzen-kdab
Copy link
Collaborator

Requires #204 #206 #207

This allows for multiple QObjects to be defined without a namespace
to separate them.
@ahayzen-kdab ahayzen-kdab force-pushed the cpp-internal-namespace branch from c73d3ff to ad159b2 Compare August 12, 2022 11:03
@ahayzen-kdab ahayzen-kdab marked this pull request as ready for review August 12, 2022 11:04
@ahayzen-kdab ahayzen-kdab force-pushed the cpp-internal-namespace branch from ad159b2 to 625d377 Compare August 12, 2022 11:33
Copy link
Collaborator

@LeonMatthesKDAB LeonMatthesKDAB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LeonMatthesKDAB LeonMatthesKDAB enabled auto-merge (squash) August 12, 2022 11:41
Copy link
Collaborator

@LeonMatthesKDAB LeonMatthesKDAB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LeonMatthesKDAB LeonMatthesKDAB merged commit 4ac75c1 into KDAB:main Aug 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants