Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cxx-qt-gen: remove CppObj type alias from C++ side #207

Merged
merged 1 commit into from
Aug 12, 2022
Merged

cxx-qt-gen: remove CppObj type alias from C++ side #207

merged 1 commit into from
Aug 12, 2022

Conversation

ahayzen-kdab
Copy link
Collaborator

Requires #204

@ahayzen-kdab ahayzen-kdab mentioned this pull request Aug 11, 2022
Merged
@ahayzen-kdab ahayzen-kdab force-pushed the cpp-drop-cppobj-alias branch from 23ba573 to dc54cfb Compare August 11, 2022 21:55
Be-ing
Be-ing previously approved these changes Aug 11, 2022
View reviewed changes
@ahayzen-kdab ahayzen-kdab marked this pull request as ready for review August 12, 2022 08:52
@ahayzen-kdab ahayzen-kdab force-pushed the cpp-drop-cppobj-alias branch from dc54cfb to b9b441f Compare August 12, 2022 09:45
LeonMatthesKDAB
LeonMatthesKDAB approved these changes Aug 12, 2022
View reviewed changes
Copy link
Collaborator

@LeonMatthesKDAB LeonMatthesKDAB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ahayzen-kdab ahayzen-kdab merged commit 2b3161d into KDAB:main Aug 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LeonMatthesKDAB LeonMatthesKDAB LeonMatthesKDAB approved these changes

@Be-ing Be-ing Be-ing left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ahayzen-kdab @Be-ing @LeonMatthesKDAB