Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deferred connection evaluation #48

Merged
merged 12 commits into from
Jan 8, 2024

Conversation

LeonMatthesKDAB
Copy link
Contributor

Closes #23

Copy link
Member

@MiKom MiKom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall I think it looks good. Added some nits and some requests/questions.

src/kdbindings/genindex_array.h Outdated Show resolved Hide resolved
src/kdbindings/connection_evaluator.h Show resolved Hide resolved
src/kdbindings/connection_evaluator.h Outdated Show resolved Hide resolved
src/kdbindings/signal.h Show resolved Hide resolved
src/kdbindings/signal.h Show resolved Hide resolved
- Add license header to connection_evaluator.h
- Use slotInvocation instead of Connection in the ConnectionEvaluator
- Add warnings that deferred connections are experimental
- Improved documentation for deferred connections
src/kdbindings/signal.h Show resolved Hide resolved
@LeonMatthesKDAB LeonMatthesKDAB merged commit 86d6bd5 into KDAB:main Jan 8, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants