Add nowarn=:all option to @check and check
#32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #6. Closes #21.
Currently, there are two ways to ask
check/@checkto throw an error if any warnings occur inside a function:@should_not_warnmacro.nowarnkeyword argument tocheck/@check. Example usage:@check f(x,y,z) nowarn=[g,h]This pull request adds a third option:
nowarn=:all, which tellscheck/@checkto throw an error if any warnings occur inside ANY function. Example usage:@check f(x) nowarn=:allThe first two options remain available.
Motivation
The first option (annotating with
@should_not_warn) requires that you manually annotate all of the functions of interest. This can be cumbersome. Additionally, this requires that you makeTraceur.jla required dependency of your package, instead of a test-only dependency.The second option (providing a list of functions in
nowarn) requires that you manually list out all of the functions of interest. This can also be cumbersome.The third option added in this pull request (setting
nowarn=:all) is quick and easy.