Discussion: Add assert_trace option to assert on the first Trace warning. #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds `@assert_trace` which raises an `AssertError` at the first Trace warning.
NHDaly
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
@assert_tracewhich raises anAssertErrorat the first Trace warning.@pfitzseb Asked me to open a PR for this. It relates to #6.
I'm not sure this is really a good solution, though, because this means it stops at the first warning, which could be desirable or not. Also, it's not a great testing interface, it'd be better if it returned false or something instead of throwing an
AssertError. (Of course one/we can always wrap this in atry/catchto return false.)