Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IPNet fix and refactoring #49

Merged
merged 4 commits into from
Apr 28, 2021
Merged

IPNet fix and refactoring #49

merged 4 commits into from
Apr 28, 2021

Conversation

Arkoniak
Copy link
Collaborator

@Arkoniak Arkoniak commented Apr 27, 2021

  1. Instead of internal IPNet implementation proper IPNets.jl is used.
  2. update, readmd5 and so forth were removed since they are unusable anymore (due to the MaxMind policy).
  3. load now returns local geodata object instead of updating global variable.
  4. load returns GeoIP.DB structure instead of DataFrame.
  5. load now supports double gz and zip file format.
  6. Additional environment variable GEOIP_ZIPFILE can be used now.
  7. Broadcasting is now directly supported for GeoIP.DB type.
  8. docs and README updated

@codecov-commenter
Copy link

codecov-commenter commented Apr 27, 2021

Codecov Report

Merging #49 (e8f952b) into master (06f0970) will increase coverage by 49.06%.
The diff coverage is 73.33%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master      #49       +/-   ##
===========================================
+ Coverage   32.74%   81.81%   +49.06%     
===========================================
  Files           4        3        -1     
  Lines         171       44      -127     
===========================================
- Hits           56       36       -20     
+ Misses        115        8      -107     
Impacted Files Coverage Δ
src/GeoIP.jl 100.00% <ø> (ø)
src/geoip-module.jl 82.35% <50.00%> (+12.78%) ⬆️
src/data.jl 80.76% <81.81%> (+49.86%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 06f0970...e8f952b. Read the comment docs.

@Arkoniak Arkoniak removed a link to an issue Apr 28, 2021
@Arkoniak Arkoniak linked an issue Apr 28, 2021 that may be closed by this pull request
@Arkoniak Arkoniak merged commit 04ac18e into JuliaWeb:master Apr 28, 2021
@Arkoniak Arkoniak deleted the fix_ipnet branch April 28, 2021 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

README: database workflow status Package does not seem to work Remove deprecated code from IPNets module
2 participants