Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated code from IPNets module #42

Closed
Arkoniak opened this issue Mar 25, 2021 · 6 comments · Fixed by #49
Closed

Remove deprecated code from IPNets module #42

Arkoniak opened this issue Mar 25, 2021 · 6 comments · Fixed by #49

Comments

@Arkoniak
Copy link
Collaborator

There are artifacts, which left from pre 0.7 era in IPNets module.

Base: start, next, done should be changed to a single iterate
@fredrikekre
Copy link
Member

I just updated the IPNets.jl package for Juila 1.X and wanted to test it with this package. Perhaps after that has been merged this package can just use IPNets.jl as a regular dependency.

@Arkoniak
Copy link
Collaborator Author

Wow, this is awesome, as soon as it will be merged, I'll make necessary changes.

@Arkoniak
Copy link
Collaborator Author

Can you give a link to updated version? Last update of https://github.com/JuliaWeb/IPNets.jl is 3 years old.

@fredrikekre
Copy link
Member

JuliaWeb/IPNets.jl#17

@fredrikekre
Copy link
Member

Merged and released as IPNets 1.0.0.

@Arkoniak Arkoniak linked a pull request Apr 28, 2021 that will close this issue
IPNet fix and refactoring #49
Merged
@Arkoniak
Copy link
Collaborator Author

Thank you, IPNets.jl used now in 0.5.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

IPNet fix and refactoring Arkoniak/GeoIP.jl
2 participants
@Arkoniak @fredrikekre