fixed inappropriate deprecation warnings when checking for sub-modules

[ExpandingMan]

This fixes #37 and #40.

I don't believe this can break anything since the function in question is used for checking for sub-modules which are unaffected by this check.

I think it's important to fix this since testing is precisely the context in which you'd want to check for deprecations so it's profoundly unhelpful to have the testing module itself throw bogus deprecation warnings.

[ExpandingMan]

I think tests are breaking due to fragile RNG. I'm going to try to fix it but I'm not entirely sure I grok what was being tested for yet...

[ExpandingMan]

Hm... so it seems that some RNG tests fail for me locally but succeed on CI/CD. Suggest we open an issue and leave it for another PR.

[ExpandingMan]

bump

[ExpandingMan]

bump

[DilumAluthge]

Who would be the right person to review this? @rfourquet, probably?

[rfourquet]

Thanks a lot @ExpandingMan, and very sorry for the delay, had a hard time keeping up with Julia development recently.
I will merge as it seems indeed harmless for submodules to function properly, although I don't really understand why the warnings were triggered (and I couldn't reproduce the issue, though I didn't try hard TBH!) So just to try to understand slightly better, would you be willing to check whether instead of your fix, you used getfield instead of eval ? (getfield is anyway probably generally better)

function submodules(m::Module)
    symbols = getfield.(Ref(m), filter!(y -> isdefined(m, y), names(m, all=true)))
    filter!(x -> issubmodule(m, x), symbols)
end

[rfourquet]

Ok, I managed to reproduce the problem thanks to #43, and using getfield instead of eval didn't help.