Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deprecation warnings from other packages pollutes the test log if running pkg> test using ReTest #43

Closed
jonalm opened this issue Oct 7, 2021 · 1 comment

Comments

@jonalm
Copy link

jonalm commented Oct 7, 2021

Hi there,

Thanks for putting up ReTest, I love it.

One small issue I noticed: consider this minimal package https://github.com/jonalm/MyTestPackage.jl

When using pkg> test, the log output gets polluted by tons of deprecation warnings, like

WARNING: GeometryBasics.TRect is deprecated, use RectT instead.
  likely near none:1
WARNING: GeometryBasics.Vec1f0 is deprecated, use Vec1f instead.
  likely near none:1
WARNING: GeometryBasics.Vec2f0 is deprecated, use Vec2f instead.
  likely near none:1
 ....

which seems to originate here https://github.com/JuliaGeometry/GeometryBasics.jl/blob/master/src/deprecated.jl

These warning do not appear when using the normal Test package, and putting the testset in the test/runtests.jl file. However, when using ReTest from the command prompt, I do not see this issue

julia> using ReTest, MyTestPackage
julia> MyTestPackage.runtests()
        Pass
foo |      1

I originally reported this issue here JuliaGeometry/GeometryBasics.jl#154 as I thought it was a GeometryBasics issue.

@rfourquet
Copy link
Collaborator

Thanks for your kind words, and very nice report with a reproducible example! This was fixed by #41, I will make a release later today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants