Recommend mean((x, y)) rather than middle((x, y))
#147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It seems more logical and simpler for users to recommend using the same function. This also helps making Statistics a standalone package (#128) as `mean` will be moved to Julia Base, but `middle` will remain in Statistics.
bkamins
approved these changes
Aug 15, 2023
ararslan
reviewed
Aug 15, 2023
src/Statistics.jl
Outdated
| @@ -109,7 +109,7 @@ if !isdefined(Base, :mean) | |||
| f(itr) | |||
| catch MethodError | |||
There was a problem hiding this comment.
Unrelated to this PR but notably not how to catch a MethodError, haha
There was a problem hiding this comment.
Woops. I've pushed a commit to make the check stricter.
There was a problem hiding this comment.
Unrelated to this PR but notably not how to catch a
MethodError, haha
haha, that was me :P. Oops.
|
Apparently this won't be required to make Statistics an upgradable stdlib, but it's probably a good idea anyway. |
ararslan
approved these changes
Aug 16, 2023
ararslan
reviewed
Aug 16, 2023
LilithHafner
approved these changes
Aug 23, 2023
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #147 +/- ##
==========================================
+ Coverage 96.99% 97.01% +0.01%
==========================================
Files 1 1
Lines 433 435 +2
==========================================
+ Hits 420 422 +2
Misses 13 13
☔ View full report in Codecov by Sentry. |
ararslan
reviewed
Aug 28, 2023
Co-authored-by: Alex Arslan <[email protected]>
ararslan
approved these changes
Aug 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems more logical and simpler for users to recommend using the same function. This also helps making Statistics a standalone package (#128) as
meanwill be moved to Julia Base, butmiddlewill remain in Statistics.This blocks JuliaLang/julia#46501.
See #131. Cc: @LilithHafner