Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare standalone package, step 2 #128

Merged
merged 5 commits into from
Aug 15, 2023
Merged

Prepare standalone package, step 2 #128

merged 5 commits into from
Aug 15, 2023

Conversation

nalimilan
Copy link
Member

@nalimilan nalimilan commented Sep 26, 2022

mean and mean! are now defined in Base.

Tests will fail until JuliaLang/julia#46501 is merged.

`mean` and `mean!` are now defined in Base.
src/Statistics.jl Outdated Show resolved Hide resolved
@nalimilan nalimilan changed the title Prepare standalone package for Julia 1.9 Prepare standalone package for Julia 1.9, step 2 Oct 4, 2022
@nalimilan
Copy link
Member Author

Given that we have a chicken-and-egg problem to get CI to pass in Statistics.jl and in Julia, I've restored definitions for mean and mean!, making them conditional on isdefined(Base, :mean). That way we can merge this here with CI passing, and then update JuliaLang/julia#46501 to use the latest Statistics.jl and CI should pass there too. Then we can drop function definitions. OK?

@nalimilan nalimilan changed the title Prepare standalone package for Julia 1.9, step 2 Prepare standalone package, step 2 Jul 14, 2023
@JuliaStats JuliaStats deleted a comment from codecov-commenter Jul 14, 2023
@nalimilan
Copy link
Member Author

I also dropped mean and mean! from the manual as that causes the Julia build to fail due to duplicate inclusion of docstrings.

@nalimilan nalimilan requested a review from ararslan July 14, 2023 18:04
@ararslan
Copy link
Member

mean and mean! are now defined in Base.

Big if true 😜

I also dropped mean and mean! from the manual as that causes the Julia build to fail due to duplicate inclusion of docstrings.

Documenter complains about having the same docstring twice? I guess that makes sense since in most cases that's probably user error. Unfortunate that they need to be removed though because of that though. So in the period between the merging of this and merging the linked Julia PR, mean(!) won't appear in any manual builds?

src/Statistics.jl Outdated Show resolved Hide resolved
@nalimilan
Copy link
Member Author

Documenter complains about having the same docstring twice? I guess that makes sense since in most cases that's probably user error. Unfortunate that they need to be removed though because of that though. So in the period between the merging of this and merging the linked Julia PR, mean(!) won't appear in any manual builds?

No, because the master branch of Statistics will only be used after merging the Julia PR. Any changes made here will have zero effect on users as long as we don't bump the commit in Julia.

Co-authored-by: Alex Arslan <[email protected]>
@codecov-commenter
Copy link

codecov-commenter commented Aug 12, 2023

Codecov Report

Patch coverage: 88.09% and project coverage change: +0.01% 🎉

Comparison is base (bb7063d) 96.98% compared to head (0f9ea53) 96.99%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #128      +/-   ##
==========================================
+ Coverage   96.98%   96.99%   +0.01%     
==========================================
  Files           1        1              
  Lines         431      433       +2     
==========================================
+ Hits          418      420       +2     
  Misses         13       13              
Files Changed Coverage Δ
src/Statistics.jl 96.99% <88.09%> (+0.01%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nalimilan nalimilan merged commit 14438ab into master Aug 15, 2023
@nalimilan nalimilan deleted the nl/1.9 branch August 15, 2023 08:46
nalimilan added a commit that referenced this pull request Aug 15, 2023
It seems more logical and simpler for users to recommend using the
same function. This also helps making Statistics a standalone package
(#128) as `mean` will be moved to Julia Base,
but `middle` will remain in Statistics.
nalimilan added a commit that referenced this pull request Aug 25, 2023
This reverts commit 14438ab.
`mean` will not be moved to Base as Statistics will remain an (upgradable)
stdlib.

Keep version at 1.11.0 though.
@nalimilan
Copy link
Member Author

Actually given that Statistics will remain an stdlib (at least for now), and simply become upgradable, mean isn't going to move to Base so this PR isn't needed anymore. #148 reverts it.

nalimilan added a commit that referenced this pull request Sep 10, 2023
This reverts commit 14438ab.
`mean` will not be moved to Base as Statistics will remain an (upgradable)
stdlib.

Keep version at 1.11.0 though, and `median` where it is as the new place
is more logical.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants