-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prepare standalone package, step 2 #128
Conversation
`mean` and `mean!` are now defined in Base.
Given that we have a chicken-and-egg problem to get CI to pass in Statistics.jl and in Julia, I've restored definitions for |
I also dropped |
Big if true 😜
Documenter complains about having the same docstring twice? I guess that makes sense since in most cases that's probably user error. Unfortunate that they need to be removed though because of that though. So in the period between the merging of this and merging the linked Julia PR, |
No, because the master branch of Statistics will only be used after merging the Julia PR. Any changes made here will have zero effect on users as long as we don't bump the commit in Julia. |
Co-authored-by: Alex Arslan <[email protected]>
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #128 +/- ##
==========================================
+ Coverage 96.98% 96.99% +0.01%
==========================================
Files 1 1
Lines 431 433 +2
==========================================
+ Hits 418 420 +2
Misses 13 13
☔ View full report in Codecov by Sentry. |
It seems more logical and simpler for users to recommend using the same function. This also helps making Statistics a standalone package (#128) as `mean` will be moved to Julia Base, but `middle` will remain in Statistics.
This reverts commit 14438ab. `mean` will not be moved to Base as Statistics will remain an (upgradable) stdlib. Keep version at 1.11.0 though.
Actually given that Statistics will remain an stdlib (at least for now), and simply become upgradable, |
mean
andmean!
are now defined in Base.Tests will fail until JuliaLang/julia#46501 is merged.