Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

avoid repeated def of models method #692

Merged
merged 1 commit into from
May 16, 2023
Merged

avoid repeated def of models method #692

merged 1 commit into from
May 16, 2023

Conversation

dmbates
Copy link
Collaborator

@dmbates dmbates commented May 16, 2023

Avoid redefinition of a method in an included file (#691)
Julia v1.10.0-DEV warns about this when running tests.

@codecov
Copy link

codecov bot commented May 16, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (b8b9b2e) 95.64% compared to head (1935c80) 95.64%.

❗ Current head 1935c80 differs from pull request most recent head b72248f. Consider uploading reports for the commit b72248f to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #692   +/-   ##
=======================================
  Coverage   95.64%   95.64%           
=======================================
  Files          35       35           
  Lines        3189     3189           
=======================================
  Hits         3050     3050           
  Misses        139      139           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@dmbates dmbates requested a review from palday May 16, 2023 15:23
@dmbates
Copy link
Collaborator Author

dmbates commented May 16, 2023

Thanks for looking at this, @palday . I don't think there needs to be even a patch release for this change - it is minor and has no effect other than to avoid some warnings on a development version of Julia.

Should I modify NEWS.md before merging the PR? If so, what would I use as the Release Notes number? Shall I just assume we will have a v4.14.1?

@palday
Copy link
Member

palday commented May 16, 2023

No need for NEWS or patch bump. It only affects tests and not user functionality.

@dmbates dmbates merged commit ba1fcf5 into main May 16, 2023
@dmbates dmbates deleted the db/qualifymethoddef branch May 16, 2023 23:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants