Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redefinition of models method in test scripts #691

Closed
dmbates opened this issue May 15, 2023 · 2 comments
Closed

Redefinition of models method in test scripts #691

dmbates opened this issue May 15, 2023 · 2 comments

Comments

@dmbates
Copy link
Collaborator

dmbates commented May 15, 2023

Julia v1.10.0-DEV versions are complaining about redefinition of models methods in the test scripts

Test Summary: | Pass  Total  Time
Missing Omit  |    2      2  0.5s
WARNING: Method definition models(Symbol) in module Main at /Users/dmbates/.julia/dev/MixedModels/test/modelcache.jl:47 overwritten on the same line (check for duplicate calls to `include`).
Test Summary: | Pass  Total  Time
isnested      |    5      5  1.3s

Should we wrap the include calls for modelcache.jl in a test of whether the method exists?

@dmbates dmbates changed the title Redefinition of models in test scripts Redefinition of models method in test scripts May 15, 2023
@palday
Copy link
Member

palday commented May 15, 2023

Yes, that sounds like a good idea to reduce the visual clutter.

@dmbates
Copy link
Collaborator Author

dmbates commented Jul 6, 2023

Closed by #692

@dmbates dmbates closed this as completed Jul 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants