-
Notifications
You must be signed in to change notification settings - Fork 422
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make Bernoulli produce Bools #1079
Conversation
tests failing at: |
The |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, I think this makes much more sense to use Bool
s here.
Codecov Report
@@ Coverage Diff @@
## master #1079 +/- ##
==========================================
+ Coverage 80.62% 80.68% +0.05%
==========================================
Files 113 113
Lines 5611 5612 +1
==========================================
+ Hits 4524 4528 +4
+ Misses 1087 1084 -3
Continue to review full report at Codecov.
|
After this PR, will |
@cossio not currently, since array generation just uses a fallback that creates an array based on the @matbesancon anything left to do for this to get merged and tagged? |
yes all good it seems, I wanted a last patch release before this one, which is now on the way |
This reverts commit 7a2f516.
This reverts commit 0574a0f.
This effectively reverts #1048 and also addresses the original issue #984.
I'm not that familiar with this codebase, but it appears that
rand(D, ...)
uses theeltype
of the distribution to create the right array container. ForBernoulli
,eltype
hit a fallback method that incorrectly returnedInt64
, so changing that toBool
fixes the issue.